Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code suggestion #6

Open
RKDUDE02 opened this issue Jul 22, 2020 · 2 comments
Open

Code suggestion #6

RKDUDE02 opened this issue Jul 22, 2020 · 2 comments

Comments

@RKDUDE02
Copy link

I notice that in GameViewController.swift that when it tries to play a sound it prints NO AUDIO PLAYER. Instead maybe we could use a UIAlert Controller telling the user that sound is not working.

@phpmaple
Copy link
Owner

phpmaple commented Jul 27, 2020

I notice that in GameViewController.swift that when it tries to play a sound it prints NO AUDIO PLAYER. Instead maybe we could use a UIAlert Controller telling the user that sound is not working.

Yep, right! We should fully-tested In pre production, and If audio files not exist we should send error message to our server instead of alert message to user, that will be better for user, this program just demonstrate, very good suggestion!

@RKDUDE02
Copy link
Author

RKDUDE02 commented Jul 27, 2020

I notice that in GameViewController.swift that when it tries to play a sound it prints NO AUDIO PLAYER. Instead maybe we could use a UIAlert Controller telling the user that sound is not working.

Yep, right! We should fully-tested In pre production, and If audio files not exist we should send error message to our server instead of alert message to user, that will be better for user, this program just demonstrate, very good suggestion!

That's even better so that we can handle it. But quick question, do we already have servers or do we need to add some? And if we need to add some i suggest that we use firebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants