fix: global import from an array value

phpmd · Jan 25, 2023 · 0c26ea8 · 0c26ea8
1 parent 31677bd
commit 0c26ea8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/main/php/PHPMD/Rule/CleanCode/MissingImport.php b/src/main/php/PHPMD/Rule/CleanCode/MissingImport.php
@@ -89,6 +89,6 @@ protected function isSelfReference(ASTNode $classNode)
      */
     protected function isGlobalNamespace(ASTNode $classNode)
     {
-        return !strpos($classNode->getImage(), '\\', 1);
+        return $classNode->getImage() !== '' && !strpos($classNode->getImage(), '\\', 1);
     }
 }
diff --git a/...les/Rule/CleanCode/MissingImport/testRuleAppliesToFunctionWithNotImportedDependencies.php b/...les/Rule/CleanCode/MissingImport/testRuleAppliesToFunctionWithNotImportedDependencies.php
@@ -20,4 +20,8 @@
 function testRuleAppliesToFunctionWithNotImportedDependencies()
 {
     $a = new \stdClass();
+
+    // Using an array value as a classname can break the code, as the node will not be an ASTClass*
+    $classes = array('\stdClass');
+    $b = new $classes[0];
 }