LongVariable rule should apply on private variables

[duncancumming]

Currently the LongVariable rule skips private variables:
https://github.com/phpmd/phpmd/blob/master/src/main/php/PHPMD/Rule/Naming/LongVariable.php#L55

The ShortVariable rule doesn't do the same.
https://github.com/phpmd/phpmd/blob/master/src/main/php/PHPMD/Rule/Naming/ShortVariable.php#L54

This isn't documented. Can we get rid of this?

[adamcameron]

I could not agree more. We still need to read private variable names just as much as the public / protected ones.

[ravage84]

Refers to change from: #16

[ravage84]

@duncancumming and @adamcameron are you interested in putting up a PR for making this a configurable as I mentioned in my comment? (Hacktoberfest, anybody?

[adamcameron]

Yeah Dunc and I (who are colleagues) were discussing this. We didn't want to charge in and make pull reqs just cos we felt like stuff ought to be different without getting a nod from the stewards of the app though.

Also... never made a pull req to this project. you got some dev guidelines or something we ought to eyeball first? We'd also need to get it cleared with our boss, but that shouldn't be too hard.

[ravage84]

We are soemwhat light on guidelines, but take this for starters:
https://github.com/phpmd/phpmd/blob/master/CONTRIBUTING.md

Also, have a look at similar PRs:
#159
#197
#198

If you still have trouble, write me via email or Skype (same ID).

[adamcameron]

OK, I've run it up the flagpole at work. Will revert shortly.