Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False "unused private method" when used in static constructor/factory #558

Open
roperto opened this issue Mar 23, 2018 · 0 comments · May be fixed by #1069
Open

False "unused private method" when used in static constructor/factory #558

roperto opened this issue Mar 23, 2018 · 0 comments · May be fixed by #1069
Assignees
@kylekatarnls
Labels
UnusedPrivateMethod
Milestone
2.16.0

Comments

@roperto
Copy link

roperto commented Mar 23, 2018

Related to #253

See for example:

public static function create() {
    $obj = new static();
    $obj->a_private_method();
}

(I know it is over simplified, you could rewrite it, but that's just an example without all the boilerplate)
@roperto roperto changed the title False "unused private method" when used in constructor/factory False "unused private method" when used in static constructor/factory Mar 23, 2018
@kylekatarnls kylekatarnls mentioned this issue Feb 17, 2024
Closed
6 tasks
@kylekatarnls kylekatarnls added this to the 2.16.0 milestone Feb 17, 2024
@kylekatarnls kylekatarnls self-assigned this Feb 17, 2024
kylekatarnls added a commit that referenced this issue Feb 17, 2024
@kylekatarnls
Recognize simple constructions of the current class for unused privat…
8c8a0b6 
…e method rule

Fix #252
Fix #558
Fix #937
@kylekatarnls kylekatarnls linked a pull request Feb 17, 2024 that will close this issue
Draft
kylekatarnls added a commit that referenced this issue Feb 24, 2024
@kylekatarnls
Recognize simple constructions of the current class for unused privat…
4c5e9dc 
…e method rule

Fix #252
Fix #558
Fix #937
kylekatarnls added a commit that referenced this issue Feb 27, 2024
@kylekatarnls
Recognize simple constructions of the current class for unused privat…
de4ed16 
…e method rule

Fix #252
Fix #558
Fix #937
kylekatarnls added a commit that referenced this issue Feb 27, 2024
@kylekatarnls
Recognize simple constructions of the current class for unused privat…
4b464d4 
…e method rule

Fix #252
Fix #558
Fix #937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylekatarnls kylekatarnls

Labels
UnusedPrivateMethod
Milestone
2.16.0
Development

Successfully merging a pull request may close this issue.

Recognize simple current-class objects for unused private method phpmd/phpmd
2 participants
@roperto @kylekatarnls