Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors #1005

Merged
merged 3 commits into from Jul 3, 2023
Merged

Update authors #1005

merged 3 commits into from Jul 3, 2023

Conversation

ravage84
Copy link
Member

  • Move original author Manuel Pichler to new section
  • Add Kyle & Tobias to main authors/maintainers
  • Add notable Kamil Szymanski & Frank Dekker to contributors

- Move original author Manuel Pichler to new section
- Add Kyle & Tobias to main authors/maintainers
- Add notable Kamil Szymanski & Frank Dekker to contributors
@AJenbo
Copy link
Member

AJenbo commented May 26, 2023

What qualifies people for the list or not?
For example I don't see a direct mapping between https://github.com/phpmd/phpmd/graphs/contributors and the list here

@kylekatarnls
Copy link
Member

kylekatarnls commented Jun 23, 2023

I guess we can get rid of the since-year mention (at least in the contributors list), I don't think it adds value, even more when it's just 1 commit.

We could generate the list like this:

(() => {
const minimumContribution = 1;
const content = {};
const users = {};

['pdepend/pdepend', 'phpmd/phpmd'].forEach(async repo => {
    content[repo] = [];
    const contributors = await (await fetch(`https://api.github.com/repos/${repo}/contributors`)).json();

    contributors.forEach(async contributor => {
        if (contributor['contributions'] < minimumContribution) {
            return;
        }

        const user = contributor['login'];
        const name = (await (await fetch(`https://api.github.com/users/${user}`)).json())['name'] || user;
        content[repo].push(`${name} / https://github.com/${user}`);
        users[user] = `${name} / https://github.com/${user}`;
    });
});

return {users, content};
})();

So today, both repos together, it's:

Manuel Pichler / https://github.com/manuelpichler
Kyle / https://github.com/kylekatarnls
Tobias van Beek / https://github.com/tvbeek
Anders Jenbo / https://github.com/AJenbo
Benjamin Eberlei / https://github.com/beberlei
Marc Würth / https://github.com/ravage84
Frank Dekker / https://github.com/frankdekker
Tomáš Procházka / https://github.com/KacerCZ
Emir Beganović / https://github.com/emirb
Kore Nordmann / https://github.com/kore
Marin Bînzari / https://github.com/SpartakusMd
Matthias Mullie / https://github.com/matthiasmullie
Nicolas Giraud / https://github.com/niconoe-
Lucas dos Santos Abreu / https://github.com/lucassabreu
SuRiKmAn / https://github.com/surikman
Arnaud Le Blanc / https://github.com/arnaud-lb
Paul R Rogers / https://github.com/paulrrogers
Gordon Oheim / https://github.com/gooh
Blaine Bublitz / https://github.com/phated
Dmitry Balabka / https://github.com/dbalabka
Markus Fasselt / https://github.com/digilist
mmucklo / https://github.com/mmucklo
Noel GUILBERT / https://github.com/noelg
offsides / https://github.com/offsides
y_ahiru / https://github.com/YAhiru
Lucian NEAG / https://github.com/Luxian
Daniel Tschinder / https://github.com/danez
Daniel Fahlke / https://github.com/Flyingmana
Jakub Zalas / https://github.com/jakzal
Marvin Caspar / https://github.com/marvincaspar
Kamil Szymanski / https://github.com/eeree
Exploit Fate / https://github.com/exploitfate
Artem Prozorov / https://github.com/artem-prozorov
Jeroen De Dauw / https://github.com/JeroenDeDauw
Přemysl Karbula / https://github.com/smuuf
Dane Powell / https://github.com/danepowell
Felipe Figueroa / https://github.com/ffflabs
Lukas Bestle / https://github.com/lukasbestle
samuelwang23 / https://github.com/samuelwang23
Jay MOULIN / https://github.com/jaymoulin
Stefan / https://github.com/zerkalica
Mark Vaughn / https://github.com/MarkVaughn
Sebastian Brandt / https://github.com/sebbrandt87
Danny van der Sluijs / https://github.com/DannyvdSluijs
Gerrit Addiks / https://github.com/addiks
Rafał Wrzeszcz / https://github.com/rafalwrzeszcz
Sebastian Bergmann / https://github.com/sebastianbergmann
Tim Martin / https://github.com/timmartin
JF Melo / https://github.com/dudemelo
martzd / https://github.com/martzd
Daniel Mason / https://github.com/Gisleburt
Francis Besset / https://github.com/francisbesset
Gennadiy Litvinyuk / https://github.com/gennadiylitvinyuk

PHPMD only

Manuel Pichler / https://github.com/manuelpichler
Marc Würth / https://github.com/ravage84
Kyle / https://github.com/kylekatarnls
Tobias van Beek / https://github.com/tvbeek
Frank Dekker / https://github.com/frankdekker
Kamil Szymanski / https://github.com/eeree
Exploit Fate / https://github.com/exploitfate
Benjamin Eberlei / https://github.com/beberlei
Artem Prozorov / https://github.com/artem-prozorov
Jeroen De Dauw / https://github.com/JeroenDeDauw
Přemysl Karbula / https://github.com/smuuf
Anders Jenbo / https://github.com/AJenbo
Dane Powell / https://github.com/danepowell
Felipe Figueroa / https://github.com/ffflabs
Lukas Bestle / https://github.com/lukasbestle
samuelwang23 / https://github.com/samuelwang23
Jay MOULIN / https://github.com/jaymoulin
Stefan / https://github.com/zerkalica
Mark Vaughn / https://github.com/MarkVaughn
Sebastian Brandt / https://github.com/sebbrandt87
Danny van der Sluijs / https://github.com/DannyvdSluijs
Gerrit Addiks / https://github.com/addiks
Rafał Wrzeszcz / https://github.com/rafalwrzeszcz
Sebastian Bergmann / https://github.com/sebastianbergmann
Tim Martin / https://github.com/timmartin
JF Melo / https://github.com/dudemelo
martzd / https://github.com/martzd
Daniel Mason / https://github.com/Gisleburt
Francis Besset / https://github.com/francisbesset
Gennadiy Litvinyuk / https://github.com/gennadiylitvinyuk

PDepend only

Manuel Pichler / https://github.com/manuelpichler
Kyle / https://github.com/kylekatarnls
Tobias van Beek / https://github.com/tvbeek
Anders Jenbo / https://github.com/AJenbo
Benjamin Eberlei / https://github.com/beberlei
Marc Würth / https://github.com/ravage84
Frank Dekker / https://github.com/frankdekker
Tomáš Procházka / https://github.com/KacerCZ
Emir Beganović / https://github.com/emirb
Kore Nordmann / https://github.com/kore
Marin Bînzari / https://github.com/SpartakusMd
Matthias Mullie / https://github.com/matthiasmullie
Nicolas Giraud / https://github.com/niconoe-
Lucas dos Santos Abreu / https://github.com/lucassabreu
SuRiKmAn / https://github.com/surikman
Arnaud Le Blanc / https://github.com/arnaud-lb
Paul R Rogers / https://github.com/paulrrogers
Gordon Oheim / https://github.com/gooh
Blaine Bublitz / https://github.com/phated
Dmitry Balabka / https://github.com/dbalabka
Markus Fasselt / https://github.com/digilist
mmucklo / https://github.com/mmucklo
Noel GUILBERT / https://github.com/noelg
offsides / https://github.com/offsides
y_ahiru / https://github.com/YAhiru
Lucian NEAG / https://github.com/Luxian
Daniel Tschinder / https://github.com/danez
Daniel Fahlke / https://github.com/Flyingmana
Jakub Zalas / https://github.com/jakzal
Marvin Caspar / https://github.com/marvincaspar

Then we can just exclude from there contributors mentioned in a previous list.

@ravage84
Copy link
Member Author

What qualifies people for the list or not? For example I don't see a direct mapping between https://github.com/phpmd/phpmd/graphs/contributors and the list here

This list was maintained manually in the past. There was no rule set behind, as far as aI understand.

But we can and should change that.

@ravage84
Copy link
Member Author

I guess we can get rid of the since-year mention (at least in the contributors list), I don't think it adds value, even more when it's just 1 commit.

I agree to remove the "since-year" annotation for the minor contributors.

We could generate the list like this:

[...]

PHPMD only

Manuel Pichler / https://github.com/manuelpichler
Marc Würth / https://github.com/ravage84
Kyle / https://github.com/kylekatarnls
Tobias van Beek / https://github.com/tvbeek
Frank Dekker / https://github.com/frankdekker
Kamil Szymanski / https://github.com/eeree
Exploit Fate / https://github.com/exploitfate
Benjamin Eberlei / https://github.com/beberlei
Artem Prozorov / https://github.com/artem-prozorov
Jeroen De Dauw / https://github.com/JeroenDeDauw
Přemysl Karbula / https://github.com/smuuf
Anders Jenbo / https://github.com/AJenbo
Dane Powell / https://github.com/danepowell
Felipe Figueroa / https://github.com/ffflabs
Lukas Bestle / https://github.com/lukasbestle
samuelwang23 / https://github.com/samuelwang23
Jay MOULIN / https://github.com/jaymoulin
Stefan / https://github.com/zerkalica
Mark Vaughn / https://github.com/MarkVaughn
Sebastian Brandt / https://github.com/sebbrandt87
Danny van der Sluijs / https://github.com/DannyvdSluijs
Gerrit Addiks / https://github.com/addiks
Rafał Wrzeszcz / https://github.com/rafalwrzeszcz
Sebastian Bergmann / https://github.com/sebastianbergmann
Tim Martin / https://github.com/timmartin
JF Melo / https://github.com/dudemelo
martzd / https://github.com/martzd
Daniel Mason / https://github.com/Gisleburt
Francis Besset / https://github.com/francisbesset
Gennadiy Litvinyuk / https://github.com/gennadiylitvinyuk

[...]

Then we can just exclude from there contributors mentioned in a previous list.

I like that, though I would only show the ones for PHPMD on the page for PHPMD (PDepend can have a similar page).

This would have been my end goal, anyway.
With this PR, i just wanted to get a discussion going and have a minimum viable change to merge.

@ravage84
Copy link
Member Author

I propose the following struture:

  1. Original Author/Maintainer
    • From & until
    • Just Manuel Picher, to honor his work
  2. Current Main Authors/Maintainers
    • From
    • To honor the current maintainer's work
  3. Past Authors/Maintainers
    • From & Until, if possible & sensible
    • Honorable mentions, like develoerp frankdekker & eeree
  4. Contributors
    • Everybody else, automatically generated
    • Either all or excluding the ones above

kylekatarnls
kylekatarnls previously approved these changes Jun 26, 2023
Add him as fourth author/maintainer, even though his first contribution was before Kyle's & Tobias' but he joined later ad maintainer.
@tvbeek tvbeek merged commit 5cc8bf8 into master Jul 3, 2023
48 of 49 checks passed
@tvbeek tvbeek deleted the authors branch July 3, 2023 19:37
@ravage84 ravage84 added this to the 2.x (unspecific) milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants