New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authors #1005
Update authors #1005
Conversation
ravage84
commented
May 26, 2023
- Move original author Manuel Pichler to new section
- Add Kyle & Tobias to main authors/maintainers
- Add notable Kamil Szymanski & Frank Dekker to contributors
- Move original author Manuel Pichler to new section - Add Kyle & Tobias to main authors/maintainers - Add notable Kamil Szymanski & Frank Dekker to contributors
What qualifies people for the list or not? |
I guess we can get rid of the since-year mention (at least in the contributors list), I don't think it adds value, even more when it's just 1 commit. We could generate the list like this: (() => {
const minimumContribution = 1;
const content = {};
const users = {};
['pdepend/pdepend', 'phpmd/phpmd'].forEach(async repo => {
content[repo] = [];
const contributors = await (await fetch(`https://api.github.com/repos/${repo}/contributors`)).json();
contributors.forEach(async contributor => {
if (contributor['contributions'] < minimumContribution) {
return;
}
const user = contributor['login'];
const name = (await (await fetch(`https://api.github.com/users/${user}`)).json())['name'] || user;
content[repo].push(`${name} / https://github.com/${user}`);
users[user] = `${name} / https://github.com/${user}`;
});
});
return {users, content};
})(); So today, both repos together, it's:
PHPMD only
PDepend only
Then we can just exclude from there contributors mentioned in a previous list. |
This list was maintained manually in the past. There was no rule set behind, as far as aI understand. But we can and should change that. |
I agree to remove the "since-year" annotation for the minor contributors.
I like that, though I would only show the ones for PHPMD on the page for PHPMD (PDepend can have a similar page). This would have been my end goal, anyway. |
I propose the following struture:
|
Add him as fourth author/maintainer, even though his first contribution was before Kyle's & Tobias' but he joined later ad maintainer.