Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe violation for CamelCaseVariableName #1026

Merged
merged 1 commit into from Aug 21, 2023

Conversation

kylekatarnls
Copy link
Member

Type: bugfix
Issue: Fix #467
Breaking change: no

  • Dedupe violation for CamelCaseVariableName
  • Use line of first occurrence instead of line of parent function
  • Add test for uncovered exceptions

And use line of first occurrence instead of line of parent function

Add test for uncovered exceptions

Fix #467
@kylekatarnls kylekatarnls added this to the 2.14.0 milestone Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (8c246f3) 89.45% compared to head (e0a5fb3) 89.49%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1026      +/-   ##
============================================
+ Coverage     89.45%   89.49%   +0.03%     
- Complexity     1198     1199       +1     
============================================
  Files           109      109              
  Lines          3082     3084       +2     
============================================
+ Hits           2757     2760       +3     
+ Misses          325      324       -1     
Files Changed Coverage Δ
...PHPMD/Rule/Controversial/CamelCaseVariableName.php 100.00% <100.00%> (+5.55%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylekatarnls kylekatarnls merged commit 208f850 into master Aug 21, 2023
30 checks passed
@kylekatarnls kylekatarnls deleted the fix/issue-467-duplicate-camel-case-violation branch August 21, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Duplicated issues
2 participants