Fix call to undefined getParent() method #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2023 10:26
…\Source\AST\AST\ASTFunction::getParent() in phpmd\src\main\php\PHPMD\Rule\CleanCode\BooleanArgumentFlag.php:60 for files like:
<?php
function sum($a, $b)
{
return ((int)$a + (int)$b);
}
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
============================================
+ Coverage 92.37% 92.40% +0.02%
- Complexity 1215 1221 +6
============================================
Files 110 110
Lines 3331 3343 +12
============================================
+ Hits 3077 3089 +12
Misses 254 254
☔ View full report in Codecov by Sentry. |
AJenbo
previously approved these changes
Sep 15, 2023
kylekatarnls
previously approved these changes
Sep 15, 2023
And restore blank lines
kylekatarnls
previously approved these changes
Sep 15, 2023
AJenbo
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Breaking change: no
Fix PHP Fatal Error: Uncaught error: Call to undefined method PDepend\Source\AST\AST\ASTFunction::getParent() in phpmd\src\main\php\PHPMD\Rule\CleanCode\BooleanArgumentFlag.php:60 for files like: