[Tentative] Drop PHP < 8

[kylekatarnls]

Type: refactoring
Breaking change: yes

This an exploration PR to see what it would take to migrate the stack for the project and verify consequences.

[AJenbo]

I have a few followups for this one :D

[codecov]

Codecov Report

Attention: Patch coverage is 95.34050% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 92.66%. Comparing base (8dae244) to head (412a07d).
Report is 27 commits behind head on 3.x.

❗ Current head 412a07d differs from pull request most recent head a076eae. Consider uploading reports for the commit a076eae to get more accurate results

Files	Patch %	Lines
src/main/php/PHPMD/AbstractRule.php	78.57%	6 Missing ⚠️
...hp/PHPMD/Rule/Controversial/CamelCaseClassName.php	0.00%	2 Missing ⚠️
...main/php/PHPMD/Rule/Controversial/Superglobals.php	0.00%	2 Missing ⚠️
...rc/main/php/PHPMD/Cache/Model/ResultCacheState.php	88.88%	1 Missing ⚠️
src/main/php/PHPMD/Renderer/HTMLRenderer.php	87.50%	1 Missing ⚠️
src/main/php/PHPMD/Rule/UnusedLocalVariable.php	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                3.x    #1054      +/-   ##
============================================
+ Coverage     92.54%   92.66%   +0.11%     
+ Complexity     1239     1238       -1     
============================================
  Files           111      111              
  Lines          3405     3447      +42     
============================================
+ Hits           3151     3194      +43     
+ Misses          254      253       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AJenbo]

Once we settle on a version and merge we can use php-cs-fixer to make migrations of old style php docs to native types and other code modinizatios automatically in follow up, that way we can heep the version deprication PR as simple to review as possible

[kylekatarnls]

Yes, but sadly many of them are incomplete, for instance, many of our PHPDoc types miss a nullable flag: getReport() which had @return Report but actually @return Report|null so it will still need manual attention.

[kylekatarnls]

And why the test fail is actually for the same reason. PHPDoc said @param int for getIntProperty but it's actually int|null and it rely on the null to throw or not the OutOfBoundException.

[AJenbo]

Well I feel that this is even more of a reason to split it in multiple PRs

[kylekatarnls]

Oh, I have already few other branches soon to be pushed. 😄

[frankdekker]

Cool! will make development much more pleasant :)

[AJenbo]

Yes, but sadly many of them are incomplete, for instance, many of our PHPDoc types miss a nullable flag: getReport() which had @return Report but actually @return Report|null so it will still need manual attention.

I prefer to first get a project to pass PHPStan level 9 before doing the conversion for this reason.

[AJenbo]

Ok, finished the review of this juggernaut. Looking forward to when we can merge this :)

[AJenbo]

Looks pretty good to me, the few remaining comments I had can easily be addressed/checked in a follow up so I'll do that as the next thing on my list.