Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues reported by PHPStan level 3 #1101

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

AJenbo
Copy link
Member

@AJenbo AJenbo commented Apr 30, 2024

Type: refactoring

Level 3:

  • return types
  • types assigned to properties

@AJenbo AJenbo added this to the 3.0.0 milestone Apr 30, 2024
@AJenbo AJenbo marked this pull request as draft April 30, 2024 21:00
@AJenbo AJenbo force-pushed the phpstan3 branch 10 times, most recently from 0634353 to 48d57af Compare May 2, 2024 21:51
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 96.09375% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 92.70%. Comparing base (d595cd6) to head (0634353).

❗ Current head 0634353 differs from pull request most recent head cd525ac. Consider uploading reports for the commit cd525ac to get more accurate results

Files Patch % Lines
src/main/php/PHPMD/Parser.php 75.00% 1 Missing ⚠️
...HPMD/Rule/Controversial/CamelCaseParameterName.php 50.00% 1 Missing ⚠️
...PHPMD/Rule/Controversial/CamelCasePropertyName.php 50.00% 1 Missing ⚠️
...c/main/php/PHPMD/Rule/Design/LongParameterList.php 50.00% 1 Missing ⚠️
...ule/Naming/ConstructorWithNameAsEnclosingClass.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x    #1101      +/-   ##
============================================
- Coverage     92.83%   92.70%   -0.14%     
- Complexity     1287     1289       +2     
============================================
  Files           111      114       +3     
  Lines          3418     3425       +7     
============================================
+ Hits           3173     3175       +2     
- Misses          245      250       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJenbo AJenbo marked this pull request as ready for review May 3, 2024 14:08
@kylekatarnls kylekatarnls merged commit 06232c4 into phpmd:3.x May 3, 2024
17 of 18 checks passed
@AJenbo AJenbo deleted the phpstan3 branch May 3, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants