Add allow-underscore option for CamelCaseParameterName & CamelCaseVariableName #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvbeek
requested changes
Apr 15, 2020
Sure, I just didn't add them in first place because the whole CamelCaseParameterName tests are missing. Trying to add them today 👍 |
|
@tvbeek I just added the missing tests, should cover the cases now 🤔 |
MarkVaughn
approved these changes
Apr 17, 2020
tvbeek
approved these changes
Apr 17, 2020
|
No problem, thanks for the fast review! |
ravage84
changed the title
|
This replaced the stale PR #363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Issue: Resolves #742
Breaking change: no
This PR adds the allow-underscore option to CamelCaseParameterName and CamelCaseVariableName to make it consistent to the other controversial rules. It is used the same way it is used by the existing controversial rules.