Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when using entire ruleset "Naming" #81

Merged
merged 1 commit into from Jul 26, 2013

Conversation

kirillsablin
Copy link

When using entire ruleset "Naming", "Property $exceptions does not exist." error occurs.

@Dynom
Copy link

Dynom commented Apr 26, 2013

The build failed due to the Github API limit, it built fine for PHP 5.3.

@Dynom
Copy link

Dynom commented Apr 29, 2013

This doesn't solve the problem, it only suppresses the error. The problem is that, even though the properties are configured, they aren't passed along to the ShortVariable rule.

This should not be merged in.

@kirillsablin
Copy link
Author

It does solve error for entire ruleset (see #66 (comment))

@Dynom
Copy link

Dynom commented May 1, 2013

Agreed, see: #66 (comment) . This issues can be resolved->closed.

@sloory
Copy link

sloory commented Jun 20, 2013

Problem still actual. Because by default in naming.xml for rule ShortVariable we have empty string:

And if i run phpmd as is i still have error.

Because in RuleSetFactory::addProperty() we will not add this property into rule PHP_PMD_Rule_Naming_ShortVariable and it will fail in method getExceptionsList().

@kirillsablin
Copy link
Author

You have an error because pull request is still not merged.

@sloory
Copy link

sloory commented Jun 22, 2013

yes, i see. But why not merged?

manuelpichler added a commit that referenced this pull request Jul 26, 2013
Fix error when using entire ruleset "Naming"
@manuelpichler manuelpichler merged commit a473345 into phpmd:master Jul 26, 2013
@ravage84 ravage84 added this to the 1.5.0 milestone Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants