Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing external info URL for UndefinedVariable #832

Merged
merged 3 commits into from Oct 18, 2020
Merged

Add missing external info URL for UndefinedVariable #832

merged 3 commits into from Oct 18, 2020

Conversation

kamioftea
Copy link
Contributor

Type: documentation update
Issue: Resolves #724
Breaking change: no

  • Adds the missing Url as suggested in the linked issue
  • Adds a test that all of the rulesets provided with PHPMD provide an external info URL

kylekatarnls
kylekatarnls approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for the automated check in unit tests.

tvbeek
tvbeek approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@tvbeek tvbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR with the test.

@tvbeek tvbeek merged commit 1964e0f into phpmd:master Oct 18, 2020
@ravage84 ravage84 added this to the 2.x (unspecific) milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvbeek tvbeek tvbeek approved these changes

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
2.x (unspecific)
Development

Successfully merging this pull request may close these issues.

UndefinedVariable does not contain externalInfoUrl in output
4 participants
@kamioftea @tvbeek @kylekatarnls @ravage84