Disallow capital letter at the beginning in CamelCasePropertyName rule #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekatarnls
previously approved these changes
Oct 6, 2020
kylekatarnls
reviewed
Oct 6, 2020
...les/Rule/Controversial/CamelCasePropertyName/testRuleDoesApplyForPropertyNameWithCapital.php
Outdated
Show resolved
Hide resolved
kylekatarnls
reviewed
Oct 6, 2020
src/test/php/PHPMD/Rule/Controversial/CamelCasePropertyNameTest.php
Outdated
Show resolved
Hide resolved
kylekatarnls
approved these changes
Oct 6, 2020
…disallow-capital-in-camel-case-property-name
MarkVaughn
approved these changes
Feb 2, 2022
|
I miss read the BC part and pressed merge to fast, so I created a revert PR. Sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue: Resolves #276
Breaking change: yes, capital letter at the beggining of property name is not allowed anymore in the CamelCasePropertyName rule