Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the naming error where possible #838

Merged
merged 1 commit into from Feb 1, 2021
Merged

Change the naming error where possible #838

merged 1 commit into from Feb 1, 2021

Conversation

tvbeek
Copy link
Member

@tvbeek tvbeek commented Oct 29, 2020

Type: Refactoring , follow our own naming rules
Issue: Part of #812
Breaking change: no

Errors left that I think is a BC break if we change it.

  1. src/main/php/PHPMD/Renderer/HTMLRenderer.php:64 Avoid excessively long variable names like $compiledHighlightRegex. Keep variable name length under 20.
  2. src/main/php/PHPMD/Rule.php:189 The 'getBooleanProperty()' method which returns a boolean should be named 'is...()' or 'has...()'

For the second point it is possible to create a new function and deprecate the old one.

@kylekatarnls kylekatarnls added this to the 2.10.0 milestone Feb 1, 2021
@kylekatarnls kylekatarnls merged commit 830897a into phpmd:master Feb 1, 2021
@tvbeek tvbeek deleted the naming_rules branch April 22, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
Refactoring
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tvbeek @kylekatarnls