Fix multiple underscores in method name when allow-underscore-test is… #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled in CamelCaseMethodName
kylekatarnls
reviewed
Dec 3, 2020
|
I see the difference now, not sure about the exact initial intent but I'm OK to relax the rule for multiple underscore chunks. |
kylekatarnls
approved these changes
Jan 7, 2021
tvbeek
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue: Resolves #851
Breaking change: no
This PR adds an extra test to allow methods like
test_some_action_i_docurrently only a single underscore is allowed.There was one test that tested methods with multiple underscores which is modified to test 2 consecutive underscores which shouldn't be allowed.