Fix #868: Option to ignore globally-namespaced classes from MissingImport #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danepowell thanks for the PR. Maybe you already got an notification / email from the GitHub actions but there are failing test. If I take a quick look it is the result of not having a default value. Can you check check and update it? (Not having a default value that keeps the current logic should also make it a breaking change) |
|
Thanks, I fixed the broken test and also added a test case for the new option. |
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
tvbeek
requested changes
Feb 27, 2021
Co-authored-by: Tobias van Beek <github@tjvb.nl>
tvbeek
approved these changes
Mar 10, 2021
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Issue: Resolves #868
Breaking change: no
See #868 for motivation. Adds a property
ignore-globalto the MissingImport rule that will cause it to ignore classes in the global namespace (i.e. classes that do not contain a backslash in their FQN).This still needs tests but I'd like maintainer approval and guidance before proceeding with that, since I'm a little intimidated by the unit test architecture. I don't know how to incorporate an optional flag into the test cases.
As an aside, kudos on maintaining a very well-organized and documented codebase, it was pretty easy to grok.