Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions and ignorepattern properties to BooleanArgumentFlag rule #983

Merged

Conversation

kylekatarnls
Copy link
Member

Type: feature
Issue: Resolves #924
Breaking change: no

@kylekatarnls kylekatarnls added this to the 2.14.0 milestone Sep 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #983 (bde506a) into master (dad0228) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #983      +/-   ##
============================================
+ Coverage     88.23%   88.64%   +0.41%     
- Complexity     1065     1074       +9     
============================================
  Files            96       96              
  Lines          2677     2696      +19     
============================================
+ Hits           2362     2390      +28     
+ Misses          315      306       -9     
Impacted Files Coverage Δ
...n/php/PHPMD/Rule/CleanCode/BooleanArgumentFlag.php 100.00% <100.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kylekatarnls kylekatarnls force-pushed the fix/issue-924-bool-arg-in-constructor branch from 6785d5b to bde506a Compare September 11, 2022 10:51
@kylekatarnls kylekatarnls merged commit 79c937c into phpmd:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

BooleanArgumentFlag triggers for a property promoted via a constructor (PHP 8)
3 participants