-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming proposal for ProcessInstance #77
Comments
@iteman If you agree to this then I could easily apply the renaming in a PR. |
@iteman What do you think about renaming the Workflow class to ProcessInstance? |
Seems good. I will rename it, and remove |
Working on a PR that does that as we speak. |
@iteman you should also revisit PHPMentors\Workflower\Process\Process class. |
According to the BPMN standard an instance of a Process Definition is called Process Instance. I suggest a rename of the
Workflow
class toProcessInstance
.The
WorkflowBuilder
class could becomeProcessDefinition
. AProcessDefinition
could have multiple versions (ProcessDefinitionVersion
) but only one of them is active.A
ProcessInstance
is usually linked to aProcessDefinitionVersion
.If we would have a
ProcessDefinition
class then we could implement methods for:ProcessInstances
;ProcessInstance
by id;ProcessInstances
from a version to the latest version.Of course these definition classes could be also implemented by users in their apps.
@iteman What do you think?
The text was updated successfully, but these errors were encountered: