Update phpunit to use highest version possible (#391)

* use highest possible PhpUnit

* update lowest phpunit

composer.json

@@ -37,7 +37,7 @@
         "nikic/php-parser": "^3|^4"
     },
     "require-dev": {
-        "phpunit/phpunit": ">=4.8.27,<=5.7.13",
+        "phpunit/phpunit": "^4.8.36 || ^5.7.27 || ^6.5.14",
         "sebastian/comparator": ">=1.2.3",
         "squizlabs/php_codesniffer": "^3.5"
     },

tests/Application/Config/File/ConfigFileReaderTest.php

@@ -3,7 +3,7 @@
 
 use Hal\Application\Config\File\ConfigFileReaderInterface;
 
-class ConfigFileReaderTest extends \PHPUnit_Framework_TestCase
+class ConfigFileReaderTest extends \PHPUnit\Framework\TestCase
 {
     public function testJsonConfigFile()
     {

tests/Application/Config/ParserTest.php

@@ -7,7 +7,7 @@
  * @group application
  * @group config
  */
-class ParserTest extends \PHPUnit_Framework_TestCase
+class ParserTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @dataProvider providesExample

tests/Component/Ast/NodeTraverserTest.php

@@ -3,9 +3,9 @@
 
 use Hal\Component\Ast\NodeTraverser;
 use PhpParser\NodeTraverser as BaseTraverser;
-use PHPUnit_Framework_TestCase;
+use PHPUnit\Framework\TestCase;
 
-class NodeTraverserTest extends PHPUnit_Framework_TestCase
+class NodeTraverserTest extends TestCase
 {
     public function testItCanBeInstantiated()
     {

tests/Component/File/FinderTest.php

@@ -3,12 +3,12 @@
 namespace Test\Hal\Component\File;
 
 use Hal\Component\File\Finder;
-use PHPUnit_Framework_TestCase;
+use PHPUnit\Framework\TestCase;
 
 /**
  * @group file
  */
-class FinderTest extends PHPUnit_Framework_TestCase
+class FinderTest extends TestCase
 {
     public function testPathsGivenAreRecoveredOverExcluded()
     {

tests/Component/Issuer/IssuerTest.php

@@ -9,7 +9,7 @@
 /**
  * @group issue
  */
-class IssuerTest extends \PHPUnit_Framework_TestCase
+class IssuerTest extends \PHPUnit\Framework\TestCase
 {
 
     public function testICanEnableIssuer()

tests/Component/Tree/GraphDeduplicatedTest.php

@@ -9,7 +9,7 @@
 /**
  * @group tree
  */
-class GraphDeduplicatedTest extends \PHPUnit_Framework_TestCase
+class GraphDeduplicatedTest extends \PHPUnit\Framework\TestCase
 {
 
     public function testEdgeDeduplication()

tests/Component/Tree/GraphTest.php

@@ -2,18 +2,14 @@
 
 namespace Test;
 
-use Hal\Component\Tree\Edge;
 use Hal\Component\Tree\Graph;
-use Hal\Component\Tree\GraphFactory;
-use Hal\Component\Tree\HashMap;
 use Hal\Component\Tree\Node;
 
 /**
  * @group tree
  */
-class GraphTest extends \PHPUnit_Framework_TestCase
+class GraphTest extends \PHPUnit\Framework\TestCase
 {
-
     public function testICanAddEdge()
     {
         $graph = new Graph();

tests/Component/Tree/HashMapTest.php

@@ -2,15 +2,13 @@
 
 namespace Test;
 
-use Hal\Component\Token\Token;
-use Hal\Component\Token\Tokenizer;
 use Hal\Component\Tree\HashMap;
 use Hal\Component\Tree\Node;
 
 /**
  * @group tree
  */
-class HashMapTest extends \PHPUnit_Framework_TestCase
+class HashMapTest extends \PHPUnit\Framework\TestCase
 {
 
     public function testICanWorkWithHashMap()
@@ -34,7 +32,6 @@ public function testICanWorkWithHashMap()
 
     public function testICanIterateThroughHashMap()
     {
-        $hash = new HashMap;
         $hash = new HashMap;
         $hash
             ->attach(new Node('A', 'value1'))

tests/Component/Tree/NodeTest.php

@@ -8,9 +8,8 @@
 /**
  * @group tree
  */
-class NodeTest extends \PHPUnit_Framework_TestCase
+class NodeTest extends \PHPUnit\Framework\TestCase
 {
-
     public function testICanWorkWithNode()
     {
 

tests/Component/Tree/Operator/CycleDetectorTest.php

@@ -2,19 +2,15 @@
 
 namespace Test;
 
-use Hal\Component\Tree\Edge;
 use Hal\Component\Tree\Graph;
-use Hal\Component\Tree\GraphFactory;
-use Hal\Component\Tree\HashMap;
 use Hal\Component\Tree\Node;
 use Hal\Component\Tree\Operator\CycleDetector;
 
 /**
  * @group tree
  */
-class CycleDetectorTest extends \PHPUnit_Framework_TestCase
+class CycleDetectorTest extends \PHPUnit\Framework\TestCase
 {
-
     public function testCycleIsDetected()
     {
         $graph = new Graph();

tests/Component/Tree/Operator/SizeOfTreeTest.php

@@ -10,7 +10,7 @@
 /**
  * @group tree
  */
-class SizeOfTreeTest extends \PHPUnit_Framework_TestCase
+class SizeOfTreeTest extends \PHPUnit\Framework\TestCase
 {
 
     /**

tests/Metric/Class_/ClassEnumVisitorTest.php

@@ -10,7 +10,7 @@
 /**
  * @group class
  */
-class ClassEnumVisitorTest extends \PHPUnit_Framework_TestCase
+class ClassEnumVisitorTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @dataProvider provideExamples

tests/Metric/Class_/Complexity/CyclomaticComplexityVisitorTest.php

@@ -8,7 +8,7 @@
 use PhpParser\NodeVisitor\NameResolver;
 use PhpParser\ParserFactory;
 
-class CyclomaticComplexityVisitorTest extends \PHPUnit_Framework_TestCase
+class CyclomaticComplexityVisitorTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @dataProvider provideExamplesForCcn

tests/Metric/Class_/Complexity/KanDefectVisitorTest.php

@@ -2,9 +2,7 @@
 namespace Test\Hal\Metric\Class_\Coupling;
 
 use Hal\Metric\Class_\ClassEnumVisitor;
-use Hal\Metric\Class_\Complexity\CyclomaticComplexityVisitor;
 use Hal\Metric\Class_\Complexity\KanDefectVisitor;
-use Hal\Metric\Class_\Complexity\McCabeVisitor;
 use Hal\Metric\Metrics;
 use PhpParser\ParserFactory;
 
@@ -13,10 +11,8 @@
  * @group kan
  * @group defect
  */
-class KanDefectVisitorTest extends \PHPUnit_Framework_TestCase
+class KanDefectVisitorTest extends \PHPUnit\Framework\TestCase
 {
-
-
     /**
      * @dataProvider provideExamples
      */

tests/Metric/Class_/Complexity/SystemComplexityVisitorTest.php

@@ -2,7 +2,6 @@
 namespace Test\Hal\Metric\Class_\Coupling;
 
 use Hal\Metric\Class_\ClassEnumVisitor;
-use Hal\Metric\Class_\Complexity\McCabeVisitor;
 use Hal\Metric\Class_\Structural\SystemComplexityVisitor;
 use Hal\Metric\Metrics;
 use PhpParser\ParserFactory;
@@ -12,10 +11,8 @@
  * @group complexity
  * @group defect
  */
-class SystemComplexityVisitorTest extends \PHPUnit_Framework_TestCase
+class SystemComplexityVisitorTest extends \PHPUnit\Framework\TestCase
 {
-
-
     /**
      * @dataProvider provideExamples
      */

tests/Metric/Class_/Component/MaintainabilityIndexVisitorTest.php

@@ -10,10 +10,8 @@
  * @group mi
  * @group complex
  */
-class MaintainabilityIndexVisitorTest extends \PHPUnit_Framework_TestCase
+class MaintainabilityIndexVisitorTest extends \PHPUnit\Framework\TestCase
 {
-
-
     /**
      * @dataProvider provideValues
      */

tests/Metric/Class_/Coupling/ExternalsVisitorTest.php

@@ -2,7 +2,6 @@
 namespace Test\Hal\Metric\Class_\Coupling;
 
 use Hal\Metric\Class_\ClassEnumVisitor;
-use Hal\Metric\Class_\Complexity\McCabeVisitor;
 use Hal\Metric\Class_\Coupling\ExternalsVisitor;
 use Hal\Metric\Metrics;
 use PhpParser\ParserFactory;
@@ -12,10 +11,8 @@
  * @group externals
  * @group coupling
  */
-class ExternalsVisitorTest extends \PHPUnit_Framework_TestCase
+class ExternalsVisitorTest extends \PHPUnit\Framework\TestCase
 {
-
-
     /**
      * @dataProvider provideExamples
      */

tests/Metric/Class_/Structural/LcomVisitorTest.php

@@ -6,10 +6,8 @@
 use Hal\Metric\Metrics;
 use PhpParser\ParserFactory;
 
-class LcomVisitorTest extends \PHPUnit_Framework_TestCase
+class LcomVisitorTest extends \PHPUnit\Framework\TestCase
 {
-
-
     /**
      * @dataProvider provideExamples
      */

tests/Metric/Class_/Text/HalsteadVisitorTest.php

@@ -10,10 +10,8 @@
  * @group halstead
  * @group metric
  */
-class HalsteadVisitorTest extends \PHPUnit_Framework_TestCase
+class HalsteadVisitorTest extends \PHPUnit\Framework\TestCase
 {
-
-
     /**
      * @dataProvider provideExamples
      */

tests/Metric/Class_/Text/LengthVisitorTest.php

@@ -10,10 +10,8 @@
  * @group loc
  * @group metric
  */
-class LengthVisitorTest extends \PHPUnit_Framework_TestCase
+class LengthVisitorTest extends \PHPUnit\Framework\TestCase
 {
-
-
     /**
      * @dataProvider provideExamples
      */

tests/Metric/Helper/RoleOfMethodDetectorTest.php

@@ -11,7 +11,7 @@
  * @group helper
  * @group parsing
  */
-class RoleOfMethodDetectorTest extends \PHPUnit_Framework_TestCase
+class RoleOfMethodDetectorTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @dataProvider provideExamples

tests/Metric/Package/PackageAbstractionTest.php

@@ -7,13 +7,13 @@
 use Hal\Metric\Metrics;
 use Hal\Metric\Package\PackageAbstraction;
 use Hal\Metric\PackageMetric;
-use PHPUnit_Framework_TestCase;
+use PHPUnit\Framework\TestCase;
 
 /**
  * @group metric
  * @group package
  */
-class PackageAbstractionTest extends PHPUnit_Framework_TestCase
+class PackageAbstractionTest extends TestCase
 {
     public function testItCalculatesTheAbstractionOfEachPackage()
     {

tests/Metric/Package/PackageCollectingVisitorTest.php

@@ -9,13 +9,13 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitor\NameResolver;
 use PhpParser\ParserFactory;
-use PHPUnit_Framework_TestCase;
+use PHPUnit\Framework\TestCase;
 
 /**
  * @group metric
  * @group package
  */
-class PackageCollectingVisitorTest extends PHPUnit_Framework_TestCase
+class PackageCollectingVisitorTest extends TestCase
 {
     public function testItUsesThePackageAndTheSubpackageAnnotationAsPackageName()
     {

tests/Metric/Package/PackageDependenciesTest.php

@@ -6,13 +6,13 @@
 use Hal\Metric\Metrics;
 use Hal\Metric\Package\PackageDependencies;
 use Hal\Metric\PackageMetric;
-use PHPUnit_Framework_TestCase;
+use \PHPUnit\Framework\TestCase;
 
 /**
  * @group metric
  * @group package
  */
-class PackageDependenciesTest extends PHPUnit_Framework_TestCase
+class PackageDependenciesTest extends TestCase
 {
     public function testItCollectsAllIncomingAndOutgoingPackageDependencies()
     {

tests/Metric/Package/PackageDistanceTest.php

@@ -6,13 +6,13 @@
 use Hal\Metric\Metrics;
 use Hal\Metric\Package\PackageDistance;
 use Hal\Metric\PackageMetric;
-use PHPUnit_Framework_TestCase;
+use \PHPUnit\Framework\TestCase;
 
 /**
  * @group metric
  * @group package
  */
-class PackageDistanceTest extends PHPUnit_Framework_TestCase
+class PackageDistanceTest extends TestCase
 {
     /**
      * @dataProvider provideExamples

tests/Metric/Package/PackageInstabilityTest.php

@@ -5,13 +5,13 @@
 use Hal\Metric\Metrics;
 use Hal\Metric\Package\PackageInstability;
 use Hal\Metric\PackageMetric;
-use PHPUnit_Framework_TestCase;
+use \PHPUnit\Framework\TestCase;
 
 /**
  * @group metric
  * @group package
  */
-class PackageInstabilityTest extends PHPUnit_Framework_TestCase
+class PackageInstabilityTest extends TestCase
 {
     public function testItCalculatesTheInstabilityOfEachPackage()
     {

tests/Metric/PackageMetricTest.php

@@ -4,9 +4,9 @@
 
 use Hal\Metric\Metric;
 use Hal\Metric\PackageMetric;
-use PHPUnit_Framework_TestCase;
+use PHPUnit\Framework\TestCase;
 
-class PackageMetricTest extends PHPUnit_Framework_TestCase
+class PackageMetricTest extends TestCase
 {
     public function testItIsAMetric()
     {

tests/Metric/System/UnitTesting/UnitTestingTest.php

@@ -8,7 +8,7 @@
 /**
  * @group unit
  */
-class UnitTestingTest extends \PHPUnit_Framework_TestCase
+class UnitTestingTest extends \PHPUnit\Framework\TestCase
 {
 
     public function testICanParseJunitXmlFile()