Improve composer package version comparison #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assume that installed version should be compared to the latest stable version of the package and not to beta, rc, ... Hence, installed version in the next RC version (or beta or whatever) should not be listed as old (color orangered)
juliendufresne
commented
Dec 23, 2017
| @@ -141,7 +141,7 @@ | |||
| return strcmp($a->name, $b->name); | |||
| }); | |||
| foreach ($packages as $package) { ?> | |||
| <tr<?php if (null !== $package->installed && $package->installed !== $package->latest) { echo ' style="color:orangered"'; }?>> | |||
| <tr<?php if (null !== $package->installed && version_compare($package->installed, $package->latest) === -1) { echo ' style="color:orangered"'; }?>> | |||
There was a problem hiding this comment.
If you use a package in beta, alpha, RC (i.e non stable) version of a package and there is no stable version above the one you installed, PhpMetrics should not warn you.
juliendufresne
commented
Dec 23, 2017
| @@ -37,8 +37,10 @@ public function get($package) | |||
| // get latest version | |||
| $latest = '0.0.0'; | |||
| foreach ((array)$json->package->versions as $version => $datas) { | |||
| $version = preg_replace('([^\.\d])', '', $version); | |||
| if (!preg_match('!\d+\.\d+\.\d+!', $version)) { | |||
| if ($version[0] === 'v') { | |||
There was a problem hiding this comment.
The only non numeric character that should be accepted is the leading "v" character that is used by convention.
Some packages have changed from a non-leading "v" to a leading "v" format. This is why we need to remove it before running the version_compare function.
|
Thank you @juliendufresne |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assume that installed version should be compared to the latest
stable version of the package and not to beta, rc, ...
Hence, installed version in the next RC version (or beta or whatever)
should not be listed as old (color orangered)