Adjust cc violation limits #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the CCN and WMC calculation results in higher CCN and especially WMC values. Therefore the threshold for violations should to be adjusted too. For the CCN 10 as a threshold is suggested by McCabe itself. For the WMC no source could be found, but in other open source metric tools 50 has been found as threshold. Applying this thresholds on symfony leeds to the following violations: | | CCN violations | WMC violations | | -------------------------- | -------------- | -------------- | | Before changing ccn | 104 | 237 | | After changing ccn | 297 | 458 | | After adjusting thresholds | 115 | 293 | Altogether when applying the new CCN calculation with the new thresholds, which are based on resources, the number of violations does not change significantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the CCN and WMC calculation results in higher CCN and especially WMC values.
Therefore the threshold for violations should to be adjusted too.
For the CCN 10 as a threshold is suggested by McCabe itself.
For the WMC no source could be found, but in other open source metric tools 50 has been found as threshold.
Applying this thresholds on symfony leeds to the following violations:
Altogether when applying the new CCN calculation with the new thresholds, which are based on resources, the number of violations does not change significantly.