Unix linebreak on Windows

[UFOMelkor]

Hi,

I think there is an error when using PHP_EOL. By using \n as linebreak on windows there are 0 lines found. With count(file($filename)) the problem does not appear. I'm not sure how to make a test case for this because it depends on the environment …

[Halleck45]

Be careful, you broke the build.

What is the auto_detect_line_endings value of your php.ini ?

I think you're right, but I prefer a better solution. For example:

// this is a not tested example
if(ini_get('auto_detect_line_endings')) {
    $loc = substr_count($content, PHP_EOL)
} else {
    $loc = sizeof(preg_split('/\r\n|\r|\n/', $content));
}

// or at least:

$loc = sizeof(preg_split('/\r\n|\r|\n/', $content));

There is a dicussion on this topic here

[UFOMelkor]

$loc = sizeof(preg_split('/\r\n|\r|\n/', $content)); also breaks the build but it might be quite useful because we need to change line 63 too.

Just for my information: How do you get the test data? tests/resources/f1.php contains 34 lines, you're testing against 33 lines. Not counting the <?php?
What about CLOC? I count 16 CLOC, you're testing against 14, counting tests/resources/f1.php#L13-15 just as single line. I'm not really deep insight metrics so you might help me a bit :-)

[UFOMelkor]

@Halleck45 Seems to work now :-)

[Halleck45]

Ok. Thank's for your work !