Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop opcache from cli actions #242

Merged
merged 1 commit into from
Nov 30, 2019
Merged

Drop opcache from cli actions #242

merged 1 commit into from
Nov 30, 2019

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Sep 30, 2019

docker-library/wordpress#407

Before a68a25c this was in a inconsistent state.

@stale
Copy link

stale bot commented Nov 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 29, 2019
@williamdes
Copy link
Member

@J0WI this needs to be merged
Can you explain why it should be removed or not?

@williamdes williamdes self-requested a review November 30, 2019 09:24
@williamdes williamdes self-assigned this Nov 30, 2019
@J0WI
Copy link
Contributor Author

J0WI commented Nov 30, 2019

This came up at nextcloud/documentation#1439:

Enabling OPcache for CLI has the following effect: it will optimize the CLI script (which takes of course more time the first time to do). However, in the case of a CLI script, it is always the first time for every single invocation of the script. The cache only lives until the process terminates, so as soon as the script ends the optimizations are gone.

See also https://stackoverflow.com/a/25047263

williamdes added a commit that referenced this pull request Nov 30, 2019
Pull-request: #242
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 4388841 into phpmyadmin:master Nov 30, 2019
@williamdes
Copy link
Member

Merged, thank you for the the explanation and contribution @J0WI !

@williamdes williamdes removed their request for review November 30, 2019 17:49
@J0WI J0WI deleted the op-cli branch November 30, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants