Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if code is still needed #12478

Closed
nijel opened this issue Aug 18, 2016 · 20 comments · Fixed by #13024
Closed

Investigate if code is still needed #12478

nijel opened this issue Aug 18, 2016 · 20 comments · Fixed by #13024
Assignees
Milestone

Comments

@nijel
Copy link
Contributor

nijel commented Aug 18, 2016

In the authentication classes there are two almost identical pieces of code:

Both these come from 0c8575c. I don't think this code is ever used, but I'm really not sure, so another pair of eyes is welcome. If it is needed, it should be shared and behave consistently across authentication methods.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected known_string to be a string, null given
Exception Type php
phpMyAdmin version 4.6.5.2
Incident count 223
Link Report#29671

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected known_string to be a string, null given
Exception Type php
phpMyAdmin version 4.6.5.2
Incident count 223
Link Report#29672

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected known_string to be a string, null given
Exception Type php
phpMyAdmin version 4.4.15.9
Incident count 163
Link Report#30020

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected known_string to be a string, null given
Exception Type php
phpMyAdmin version 4.4.15.9
Incident count 163
Link Report#30021

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.7.1
Incident count 6
Link Report#32804

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.7.1
Incident count 6
Link Report#32805

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected known_string to be a string, null given
Exception Type php
phpMyAdmin version 4.6.6
Incident count 4
Link Report#31075

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected known_string to be a string, null given
Exception Type php
phpMyAdmin version 4.6.6
Incident count 4
Link Report#31076

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.7.1
Incident count 2
Link Report#32744

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.7.1
Incident count 2
Link Report#32745

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.6.5
Incident count 1
Link Report#30289

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.6.5
Incident count 1
Link Report#30290

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.6.5.2
Incident count 1
Link Report#30762

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.6.5.2
Incident count 1
Link Report#30763

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.4.15.10
Incident count 1
Link Report#31459

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.4.15.10
Incident count 1
Link Report#31460

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.7.0
Incident count 1
Link Report#32038

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.7.0
Incident count 1
Link Report#32039

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.7.0
Incident count 1
Link Report#32308

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel
Copy link
Contributor Author

nijel commented Jun 15, 2017

Param Value
Error Type Warning
Error Message hash_equals(): Expected user_string to be a string, boolean given
Exception Type php
phpMyAdmin version 4.7.0
Incident count 1
Link Report#32309

This comment is posted automatically by phpMyAdmin's error-reporting-server.

@nijel nijel self-assigned this Jun 15, 2017
@nijel nijel added this to the 4.8.0 milestone Jun 15, 2017
@nijel nijel reopened this Jun 15, 2017
@nijel nijel closed this as completed Jun 15, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant