Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package guzzle/guzzle for guzzlehttp/guzzle #12716

Closed
arimourao opened this issue Nov 19, 2016 · 8 comments
Closed

Change package guzzle/guzzle for guzzlehttp/guzzle #12716

arimourao opened this issue Nov 19, 2016 · 8 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Milestone

Comments

@arimourao
Copy link
Contributor

arimourao commented Nov 19, 2016

Steps to reproduce

  1. clone the repo
  2. run composer install
  3. message alerts at the end that guzzle/guzzle package is abandoned. Suggests to use guzzlehttp/guzzle instead

Expected behaviour

Composer should install everything without warnings

@devenbansod
Copy link
Member

I think we don't have a direct dependency on guzzle, but I think it is php-coveralls (on which we have a require-dev dependency).

I believe since their composer.json has already got the change, the next major release of php-coveralls (i.e. 2.0) (and we shifting our dependency to the newer version, which is based on the compatibility of the minimum PHP version that it requires and the one that we require) would remove that warning in future.

@devenbansod devenbansod added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Nov 19, 2016
@nijel nijel self-assigned this Nov 30, 2016
@nijel
Copy link
Contributor

nijel commented Nov 30, 2016

This is not really our bug, see php-coveralls/php-coveralls#80 and php-coveralls/php-coveralls#152.

@nijel
Copy link
Contributor

nijel commented Jun 13, 2017

This has been fixed in php-coveralls/php-coveralls@07473e6, but it still is not part of released version.

@ibennetch
Copy link
Member

ibennetch commented Jun 15, 2017 via email

@nijel
Copy link
Contributor

nijel commented Jun 15, 2017

Another way to fix this for us is to stop using coveralls, would anybody mind?

@MauricioFauth
Copy link
Member

Is there any alternative to satooshi/php-coveralls?
Is there any benefit in continuing to use Coveralls?

@ibennetch
Copy link
Member

ibennetch commented Jun 15, 2017 via email

@nijel
Copy link
Contributor

nijel commented Jun 15, 2017

We have codecov as well, so I don't think we will miss it much...

@nijel nijel added Bug A problem or regression with an existing feature and removed question Used when we need feedback from the submitter or when the issue is a question about PMA labels Jun 15, 2017
@nijel nijel reopened this Jun 15, 2017
@nijel nijel added this to the 4.7.2 milestone Jun 15, 2017
@nijel nijel closed this as completed in 3675c1e Jun 15, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants