PMA does not detect real server character set

[mlapkin]

phpmyadmin/index.php

Line 329 in 762129b

$unicode = Charsets::$mysql_charset_map['utf-8'];

Suddenly PMA always shows your server has UTF-8 character set by default even it isn't.

[nijel]

But phpMyAdmin configures the connection charset to utf-8, so this seems correct...

phpmyadmin/libraries/classes/DatabaseInterface.php

Lines 1420 to 1466 in 762129b

	if ($this->_version_int > 50503) {
	$default_charset = 'utf8mb4';
	$default_collation = 'utf8mb4_general_ci';
	} else {
	$default_charset = 'utf8';
	$default_collation = 'utf8_general_ci';
	}
	$collation_connection = $GLOBALS['PMA_Config']->get('collation_connection');
	if (! empty($collation_connection)) {
	$this->query(
	"SET CHARACTER SET '$default_charset';",
	$link,
	self::QUERY_STORE
	);
	/* Automatically adjust collation if not supported by server */
	if ($default_charset == 'utf8'
	&& strncmp('utf8mb4_', $collation_connection, 8) == 0
	) {
	$collation_connection = 'utf8_' . substr($collation_connection, 8);
	}
	$result = $this->tryQuery(
	"SET collation_connection = '"
	. $this->escapeString($collation_connection, $link)
	. "';",
	$link,
	self::QUERY_STORE
	);
	if ($result === false) {
	trigger_error(
	__('Failed to set configured collation connection!'),
	E_USER_WARNING
	);
	$this->query(
	"SET collation_connection = '"
	. $this->escapeString($collation_connection, $link)
	. "';",
	$link,
	self::QUERY_STORE
	);
	}
	} else {
	$this->query(
	"SET NAMES '$default_charset' COLLATE '$default_collation';",
	$link,
	self::QUERY_STORE
	);
	}

[mlapkin]

Code above is about configuring collation_connection variable while I'm talking about character_set_server one which I believe developers wanted to display in 'Server charset' line.
Currently even if I have a server configured with character_set_server set to latin1, that line will still display 'UTF-8' although it's not true.

[nijel]

The referenced code does set both collation and character set. So no matter what character set was used on the server, the connection will use utf-8.