Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap button class missing #15024

Open
kunalvishnoi opened this issue Mar 15, 2019 · 6 comments
Open

Bootstrap button class missing #15024

kunalvishnoi opened this issue Mar 15, 2019 · 6 comments
Labels
question Used when we need feedback from the submitter or when the issue is a question about PMA ui Issues relating to the user interface

Comments

@kunalvishnoi
Copy link

Bootstrap btn btn-primary class should be used in APPLY button as old class ui-button is used and btn btn-secondary class should be used in CANCEL button in Navigation Panel setting modal.

Current View

php

Future View
php2

I would like to work on the same

@kunalvishnoi
Copy link
Author

After shifting phpMyAdmin to bootstrap-4 all buttons should have a new bootstrap button class like btn btn-primary or btn btn-secondary but Navigation Panel setting modal still have old ui-button class ,

@AghaSaad04
Copy link
Contributor

Hey @kunalvishnoi! Can you please review that, because this is not the problem on my side

@kunalvishnoi
Copy link
Author

@AghaSaad04 please check the Navigation Panel setting modal by clicking top left setting symbol and inspect the button code.
I found ui-button ui-corner-all ui-widget class instead of any bootstrap-4 class.

@williamdes williamdes added the ui Issues relating to the user interface label Apr 2, 2019
@murex971
Copy link
Contributor

@kunalvishnoi when I'm inspecting the mentioned buttons , I could find the Bootstrap classes.
Unable to reproduce your issue.

@williamdes williamdes added this to Triage zone in Enhancements Jan 23, 2020
@williamdes williamdes moved this from Triage zone to Interface in Enhancements Jan 24, 2020
@rabeehrz
Copy link
Contributor

@williamdes Is anyone working on this? If not, may I?

@williamdes
Copy link
Member

@williamdes Is anyone working on this? If not, may I?

@rabeehrz Nobody commented recently, you can work on this one if you want

Use master branch for this one

@williamdes williamdes self-assigned this Jan 27, 2020
@williamdes williamdes added this to the 5.1.0 milestone Jan 27, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 27, 2020
@williamdes williamdes removed the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 4, 2020
@williamdes williamdes removed their assignment Jul 25, 2020
@williamdes williamdes removed this from the 5.1.0 milestone Feb 9, 2021
@williamdes williamdes added this to the 5.2.1 milestone Oct 18, 2022
@williamdes williamdes added the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Oct 25, 2022
@williamdes williamdes removed this from the 5.2.1 milestone Oct 25, 2022
@williamdes williamdes added question Used when we need feedback from the submitter or when the issue is a question about PMA and removed affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Used when we need feedback from the submitter or when the issue is a question about PMA ui Issues relating to the user interface
Projects
Enhancements
  
Interface
Development

Successfully merging a pull request may close this issue.

5 participants