Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index separation border #17534

Closed
nunoperalta opened this issue May 18, 2022 · 6 comments · Fixed by #17796
Closed

Index separation border #17534

nunoperalta opened this issue May 18, 2022 · 6 comments · Fixed by #17796
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@nunoperalta
Copy link

Hey

On 5.2.0, it's hard to differentiate each index, when they have multiple columns.

Before, the separations used to be clearer (more contrast).

Now, it just seems like a big table, like if all was the same index.

image

@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels May 28, 2022
@williamdes williamdes added this to the 5.2.1 milestone May 28, 2022
@williamdes
Copy link
Member

Hi @nunoperalta
Some changes have been done to tables for #17455 but I confirm that a stripped table would be easier to read

@williamdes
Copy link
Member

Just did some debug, this is because each row is in a tbody
With only one tbody it would work

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 14, 2022
@williamdes
Copy link
Member

williamdes commented Oct 15, 2022

Hi @nunoperalta
After applying #17796 locally here is what it looks like
image
I am not sure if it is right that the second line of the composite index is another color

@nunoperalta
Copy link
Author

Hey @williamdes

I use the classic UI, but what I meant when I raised this issue is that before this update, each index/row had a proper border, to clearly separate each index.

Even yesterday, actually, I was confused whether one of the composite columns belongs to which index, because of the lack of borders.

I believe that having different background colors can also help, yes.
The columns of the index probably shouldn't alternate columns, as you said above.

Thank you very much.

@williamdes
Copy link
Member

Hey @williamdes

I use the classic UI, but what I meant when I raised this issue is that before this update, each index/row had a proper border, to clearly separate each index.

Even yesterday, actually, I was confused whether one of the composite columns belongs to which index, because of the lack of borders.

I believe that having different background colors can also help, yes. The columns of the index probably shouldn't alternate columns, as you said above.

Thank you very much.

Thank you for the feedback, that will be a left over to fix then. The row coloring is now fixed

@williamdes williamdes self-assigned this Oct 18, 2022
@nunoperalta
Copy link
Author

that will be a left over to fix then

If the colors alternate, I think that's good enough.
That's probably how it was before anyway.

Yeah, I confirm that my issue at the moment is that all rows have the same color, and that's what confuses me a lot.
Alternating colors is the fix for this issue I reported :-)

Thank you!

@williamdes williamdes added the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Oct 25, 2022
@williamdes williamdes modified the milestone: 5.2.1 Oct 25, 2022
@williamdes williamdes removed the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Oct 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants