Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column dropped unintentionally #17353

Closed
kamil-tekiela opened this issue Feb 7, 2022 · 8 comments · Fixed by #17678
Closed

Column dropped unintentionally #17353

kamil-tekiela opened this issue Feb 7, 2022 · 8 comments · Fixed by #17678
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue help wanted
Projects
issues
Milestone
6.0.0

Comments

@kamil-tekiela
Copy link
Contributor

Describe the bug

The last command that showed the confirmation popup seems to be remembered and is executed whenever another command is triggered.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Structure' tab of any table

  2. Click on 'Drop' button beside any column
    image

  3. Close the popup but do not click "ok"
    image

  4. Click "more" and create an index on the column
    image

  5. The column is dropped!

Expected behavior

Whenever I click on "close" the previous action should be forgotten. It should not be possible to drop a column without my confirmation.

Server configuration

  • Operating system: Windows
  • Web server: Apache
  • Database version:
  • PHP version: PHP 8 and PHP 8.1
  • phpMyAdmin version: master

Client configuration

  • Browser: Chrome
  • Operating system: Windows

Additional context

I am not sure if it's just on my machine or if it is a problem in JavaScript. I don't have time to debug it now, which is why I am leaving a bug report.
@liviuconcioiu
Copy link
Contributor

I can confirm it happens on master. The first time wasn't any message at all, the second time, was an error that the column was already deleted and cannot add index.

08.02.2022_03.20.36_REC.mp4

@williamdes williamdes added this to the 5.2.1 milestone May 28, 2022
@williamdes williamdes added Bug A problem or regression with an existing feature help wanted good first issue labels May 28, 2022
@williamdes williamdes added this to Needs triage in issues via automation May 28, 2022
@williamdes williamdes moved this from Needs triage to Reproduced in issues May 28, 2022
@sidearrow
Copy link
Contributor

Thank you for your developmemt of great product 🙇‍♂
I'd like to fix this bug. Could you tell me from which branch to create branch? (from QA_5_2 ?)
I've investigated how to fix, will submit pull request in the next few days.

@williamdes
Copy link
Member

Thank you for your developmemt of great product 🙇‍♂ I'd like to fix this bug. Could you tell me from which branch to create branch? (from QA_5_2 ?) I've investigated how to fix, will submit pull request in the next few days.

Hi @sidearrow
Thank you for your nice message, you can create a branch from QA_5_2 for your PR and submit it. I will gladly review it 👍🏻

@sidearrow
Copy link
Contributor

@williamdes
Thank you for your response!
Sorry, I just found that this bug occurs on the master branch, but not on QA_5_2. So, I'll try to fix it from the master branch.

sidearrow added a commit to sidearrow/phpmyadmin that referenced this issue Aug 7, 2022
@sidearrow
Fixed unintentional column deletion
312161c 
phpmyadmin#17353
@williamdes
Copy link
Member

@williamdes Thank you for your response! Sorry, I just found that this bug occurs on the master branch, but not on QA_5_2. So, I'll try to fix it from the master branch.

If you tested that it does not occur on 5.2 then okay ;)

@sidearrow sidearrow mentioned this issue Aug 7, 2022
Merged
6 tasks
@sidearrow
Copy link
Contributor

@williamdes
Okay! I've made MR, if you don't need it, I'll close.

@williamdes williamdes added the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Oct 25, 2022
@williamdes williamdes removed this from the 5.2.1 milestone Oct 25, 2022
@williamdes

This comment was marked as outdated.

Sign in to view
@williamdes williamdes self-assigned this Nov 25, 2022
@williamdes williamdes removed the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Nov 25, 2022
@williamdes williamdes added this to the 5.2.1 milestone Nov 25, 2022
@williamdes
Copy link
Member

Edit: I can reproduce this one on 5.3

@williamdes williamdes modified the milestones: 5.2.1, 5.3.0 Nov 25, 2022
issues automation moved this from Reproduced to Closed Nov 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue help wanted
Projects
issues
  
Closed
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix #17353 - unintentional column deletion sidearrow/phpmyadmin
4 participants
@kamil-tekiela @williamdes @liviuconcioiu @sidearrow