"Show All" shows error message

[smalos]

Describe the bug

When I click the "show all" checkbox, an error message is shown

To Reproduce

Steps to reproduce the behavior:

1. Open any table
2. On the Browse tab, tick "Show All"
3. Select "OK" in the confirm dialog ("Do you really want to see all of the rows? For a big table this could crash the browser.")
4. Error is shown

Browse mode Browse mode Customize browse mode. Browse mode Table navigation bar Use only icons, only text or both. Icons Text Both How to display various action links Use only icons, only text or both. Icons Text Both Allow to display all the rows Whether a user should be displayed a "show all (rows)" button. Maximum number of rows to display Number of rows displayed when browsing a result set. If the result set contains more rows, "Previous" and "Next" links will be shown. 25 50 100 250 500 Default sorting order SMART - i.e. descending order for columns of type TIME, DATE, DATETIME and TIMESTAMP, ascending order otherwise. ASC DESC SMART Highlight pointer Highlight row pointed by the mouse cursor. Row marker Highlight selected rows. Grid editing: trigger action Click Double click Disabled Grid editing: save all edited cells at once Repeat headers Repeat the headers every X cells, 0 deactivates this feature. Limit column characters Maximum number of characters shown in any non-numeric column on browse view. Where to show the table row links These are Edit, Copy and Delete links. Nowhere Left Right Both Show row links anyway Whether to show row links even in the absence of a unique key. Primary key default sort order Default sort order for tables with a primary key. None Ascending Descending Remember table's sorting When browsing tables, the sorting of each table is remembered. Relational display For display Options key display column 


if (typeof window.configInlineParams === 'undefined' || !Array.isArray(window.configInlineParams)) {
window.configInlineParams = [];
}
window.configInlineParams.push(function () {
window.Config.registerFieldValidator('MaxRows', 'validatePositiveNumber', true);
window.Config.registerFieldValidator('RepeatCells', 'validateNonNegativeNumber', true);
window.Config.registerFieldValidator('LimitChars', 'validatePositiveNumber', true);

$.extend(window.Messages, {
'error_nan_p': 'Not a positive number!',
'error_nan_nneg': 'Not a non-negative number!',
'error_incorrect_port': 'Not a valid port number!',
'error_invalid_value': 'Incorrect value!',
'error_value_lte': 'Value must be less than or equal to %!',
});

$.extend(window.defaultValues, {
'TableNavigationLinksMode': ['icons'],
'ActionLinksMode': ['both'],
'ShowAll': false,
'MaxRows': ['25'],
'Order': ['SMART'],
'BrowsePointerEnable': true,
'BrowseMarkerEnable': true,
'GridEditing': ['double-click'],
'SaveCellsAtOnce': false,
'RepeatCells': '100',
'LimitChars': '50',
'RowActionLinks': ['left'],
'RowActionLinksWithoutUnique': false,
'TablePrimaryKeyOrder': ['NONE'],
'RememberSorting': true,
'RelationalDisplay': ['K']
});
});
if (typeof window.configScriptLoaded !== 'undefined' && window.configInlineParams) {
window.Config.loadInlineConfig();
Browse mode Browse mode Customize browse mode. Browse mode Table navigation bar Use only icons, only text or both. Icons Text Both How to display various action links Use only icons, only text or both. Icons Text Both Allow to display all the rows Whether a user should be displayed a "show all (rows)" button. Maximum number of rows to display Number of rows displayed when browsing a result set. If the result set contains more rows, "Previous" and "Next" links will be shown. 25 50 100 250 500 Default sorting order SMART - i.e. descending order for columns of type TIME, DATE, DATETIME and TIMESTAMP, ascending order otherwise. ASC DESC SMART Highlight pointer Highlight row pointed by the mouse cursor. Row marker Highlight selected rows. Grid editing: trigger action Click Double click Disabled Grid editing: save all edited cells at once Repeat headers Repeat the headers every X cells, 0 deactivates this feature. Limit column characters Maximum number of characters shown in any non-numeric column on browse view. Where to show the table row links These are Edit, Copy and Delete links. Nowhere Left Right Both Show row links anyway Whether to show row links even in the absence of a unique key. Primary key default sort order Default sort order for tables with a primary key. None Ascending Descending Remember table's sorting When browsing tables, the sorting of each table is remembered. Relational display For display Options key display column 


if (typeof window.configInlineParams === 'undefined' || !Array.isArray(window.configInlineParams)) {
window.configInlineParams = [];
}
window.configInlineParams.push(function () {
window.Config.registerFieldValidator('MaxRows', 'validatePositiveNumber', true);
window.Config.registerFieldValidator('RepeatCells', 'validateNonNegativeNumber', true);
window.Config.registerFieldValidator('LimitChars', 'validatePositiveNumber', true);

$.extend(window.Messages, {
'error_nan_p': 'Not a positive number!',
'error_nan_nneg': 'Not a non-negative number!',
'error_incorrect_port': 'Not a valid port number!',
'error_invalid_value': 'Incorrect value!',
'error_value_lte': 'Value must be less than or equal to %!',
});

$.extend(window.defaultValues, {
'TableNavigationLinksMode': ['icons'],
'ActionLinksMode': ['both'],
'ShowAll': false,
'MaxRows': ['25'],
'Order': ['SMART'],
'BrowsePointerEnable': true,
'BrowseMarkerEnable': true,
'GridEditing': ['double-click'],
'SaveCellsAtOnce': false,
'RepeatCells': '100',
'LimitChars': '50',
'RowActionLinks': ['left'],
'RowActionLinksWithoutUnique': false,
'TablePrimaryKeyOrder': ['NONE'],
'RememberSorting': true,
'RelationalDisplay': ['K']
});
});
if (typeof window.configScriptLoaded !== 'undefined' && window.configInlineParams) {
window.Config.loadInlineConfig();
}

Expected behavior

No error is displayed and all rows are displayed

Server configuration

• Web server: Apache
• Database version: 10.3.36-MariaDB
• PHP version: 8.1.11
• phpMyAdmin version: 5.3.0-dev+20221010.6785c97d22

Client configuration

• Browser: Chrome, FF
• Operating system: Windows 11

[williamdes]

Does this also occur on 5.2?

[smalos]

@williamdes There's no issue with 5.2

[aliber4079]

Also it works as is on the master branch in php7.3.5 but has the bug with php8.1.10

[aliber4079]

I'm trying to figure out how to do a pull request, it might take me a week to figure out the process

aliber4079@9a411e1