Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Query to Clipboard Feature from the Modal-Box. #17876

Open
vimalMK opened this issue Nov 7, 2022 · 4 comments
Open

Copy Query to Clipboard Feature from the Modal-Box. #17876

vimalMK opened this issue Nov 7, 2022 · 4 comments
Labels
enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface
Milestone

Comments

@vimalMK
Copy link
Contributor

vimalMK commented Nov 7, 2022

Is your feature request related to a problem? Please describe.

When performing some quick actions such as deleting tables , database or selecting records etc. The pop up modal shows a confirmation with query as a string.

image

Describe the solution you'd like

Instead if its a clipboard , then copying the query will be click of a button away rather drag copying the text. This will help users who always perform SQL actions and copy the query for migration (we do that all the time). Good to have this :)

clipboard.webm

image

Describe alternatives you've considered

Else keep it as it is.

Additional context

  • I can take this issue and work on it, if the team thinks its a reasonable change 💯
@vimalMK vimalMK changed the title Copy to Clipboard Feature from the Modal-Box. Copy Query to Clipboard Feature from the Modal-Box. Nov 7, 2022
@williamdes
Copy link
Member

Hi @vimalMK
It's a very good feature. I think you should first Functions.highlightSql(htmlElement) and then make the text selectable for manyal copy and also add the nice feature to copy to clipboard. If that sounds okay ?

@williamdes williamdes added the enhancement A feature request for improving phpMyAdmin label Nov 7, 2022
@williamdes williamdes added this to the 5.3.0 milestone Nov 7, 2022
@vimalMK
Copy link
Contributor Author

vimalMK commented Nov 7, 2022

Hi @vimalMK It's a very good feature. I think you should first Functions.highlightSql(htmlElement) and then make the text selectable for manyal copy and also add the nice feature to copy to clipboard. If that sounds okay ?

@williamdes Sounds Great!! I think that works better.

@ibennetch
Copy link
Member

ibennetch commented Nov 8, 2022 via email

@williamdes williamdes added the ui Issues relating to the user interface label Nov 8, 2022
@vimalMK
Copy link
Contributor Author

vimalMK commented Nov 9, 2022

Working on this feature for 5.3.

Meanwhile Hey @williamdes

I have some questions regarding the styling. I know each theme is having its own CSS . Just wondering is there a common CSS file which applies to all the themes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface
Projects
None yet
Development

No branches or pull requests

3 participants