Unexpected token. (near ;)

[liviuconcioiu]

Describe the bug

Something has changed in the past weeks that is causing a Unexpected token. (near ;) error on phpMyAdmin 5.2.2-dev and 6.0.0-dev for every query that is edited and has ; at the end, no matter what you type.

Strange, it doesn't happen on the demo server.

To Reproduce

Steps to reproduce the behavior:

1. Go to https://www.phpmyadmin.net/downloads/
2. Download phpMyAdmin 5.2+snapshot
3. Edit a query with ; at the end
4. See error

Expected behavior

No Unexpected token. (near ;) error should be given.

Screenshots

07.06.2023_13.03.22_REC.mp4

Server configuration

• phpMyAdmin version: 5.2.2-dev, 6.0.0-dev

[williamdes]

Can you confirm what snapshot you are using ?
We just released 5.8.0 (#449)

[liviuconcioiu]

Latest versions, from yesterday, with 5.8.0.

[williamdes]

Seems not to be in the parser, let's move it to phpMyAdmin main

$ echo 'SELECT * FROM `actor`' | ./bin/lint-query 
$ echo 'SELECT * FROM `actor` ORDER BY `actor_id` ASC' | ./bin/lint-query 
$ echo 'SELECT * FROM `actor` ORDER BY `actor_id` ASC;' | ./bin/lint-query 
$ echo 'SELECT * FROM `actor` ORDER BY `actor_id` ASC;' | ./bin/highlight-query 
SELECT
    *
FROM
    `actor`
ORDER BY

[kamil-tekiela]

It's caused by this commit 99881de but I don't know why and also don't know why this change was introduced.

It still happens on 6.0 but the errors from Linter aren't always showing up on the UI.

[williamdes]

Oh!
Thanks for the hint, it's probably missing a condition
It's the lint route for procedures and functions :/