Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search doesn't work with IN (...), NOT IN (...) operators on INT column types with no foreign key #18542

Open
liviuconcioiu opened this issue Jul 18, 2023 · 3 comments
Open

Search doesn't work with IN (...), NOT IN (...) operators on INT column types with no foreign key #18542

liviuconcioiu opened this issue Jul 18, 2023 · 3 comments
Labels
affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) Bug A problem or regression with an existing feature confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone
5.2.2

Comments

@liviuconcioiu
Copy link
Contributor

liviuconcioiu commented Jul 18, 2023 •
edited
Loading

Describe the bug

Search doesn't work with IN (...), NOT IN (...), BETWEEN, NOT BETWEEN operators on INT column types with no foreign key.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://demo.phpmyadmin.net/master/public/index.php?route=/table/search&db=sakila&table=actor
  2. For actor_id select IN (...) operator
  3. Enter 1,2 as value
  4. Click Go
  5. Search isn't working

Expected behavior

Search should work with both operators.

Screenshots

18.07.2023_11.20.59_REC.mp4

Server configuration

  • phpMyAdmin version: 5.2.2-dev, 6.0.0-dev
@williamdes williamdes added Bug A problem or regression with an existing feature affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set labels Jul 18, 2023
@williamdes williamdes added this to the 6.0.0 milestone Jul 18, 2023
@liviuconcioiu
Copy link
Contributor Author

@williamdes it also happens on 5.2.2-dev, if there is a space between values. It also happens for BETWEEN and NOT BETWEEN (here a space is added).

1, 2 instead of 1,2.

@williamdes williamdes added affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set labels Jul 26, 2023
@williamdes williamdes removed this from the 6.0.0 milestone Jul 26, 2023
@williamdes
Copy link
Member

I did some recent changes to this rules with adding a dedicated regex
I assume my fix has some kind of flaw

@williamdes williamdes added this to the 5.2.2 milestone Jul 26, 2023
@MoonE
Copy link
Contributor

MoonE commented Jul 26, 2023

On 6.0.0 the field is a number field for integer columns, which only allows single numbers regardless of the validation function.

@MoonE MoonE mentioned this issue Jul 26, 2023
Draft
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) Bug A problem or regression with an existing feature confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Milestone
5.2.2
Development

No branches or pull requests
3 participants
@MoonE @williamdes @liviuconcioiu