Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fallen] Add background to selected/marked table row #32

Merged
merged 1 commit into from Nov 15, 2020
Merged

[Fallen] Add background to selected/marked table row #32

merged 1 commit into from Nov 15, 2020

Conversation

renandecarlo
Copy link
Contributor

It's annoying not having a selected background on tables with a lot of rows, you have to be based solely on the blue marker on the beginning, often having to get back just to check if it's selected.

@williamdes
Copy link
Member

Can please you post screenshots @renandecarlo ?

@renandecarlo
Copy link
Contributor Author

Sure. It's just a minor thing to help out with identifying.

Before:
2019-02-18 14_52_34-127 0 0 1 _ 127 0 0 1 _ mysql _ innodb_index_stats _ phpmyadmin 4 8 5

After:
2019-02-18 14_51_44-127 0 0 1 _ 127 0 0 1 _ mysql _ innodb_index_stats _ phpmyadmin 4 8 5

williamdes
williamdes approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you !

@225junior
Copy link

Danke!

@williamdes
Copy link
Member

@fransallen can you review the change of your theme ?
Added by #16

@ibennetch ibennetch merged commit 6b1c815 into phpmyadmin:master Nov 15, 2020
ibennetch added a commit that referenced this pull request Nov 15, 2020
@ibennetch
Increase Fallen version number to release several minor fixes:
6c406af 
* #32 Add a background highlight to selected rows in the browse page
* #37 Label color in table pagination area
* #38 Fix for slightly offset row height on some menu items

Fixes a packaging problem with 0.7.2.

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@ibennetch
Copy link
Member

I have just released Fallen 0.7.3 to incorporate this fix. Sorry for the delay and thank you for your submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@renandecarlo @williamdes @225junior @ibennetch