Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New 5.1/5.2 theme fistu #64

Merged
merged 1 commit into from Jan 1, 2023
Merged

New 5.1/5.2 theme fistu #64

merged 1 commit into from Jan 1, 2023

Conversation

khadkamhn
Copy link
Contributor

Can you please review this theme?

@williamdes
Copy link
Member

Hi @khadkamhn
What license are the fonts/* files ?

@williamdes williamdes added the new-theme A request to add a new theme label Mar 4, 2021
@khadkamhn
Copy link
Contributor Author

khadkamhn commented Mar 5, 2021 •
edited

@williamdes

Please check the above url.
https://github.com/feathericons/feather/blob/master/LICENSE

@williamdes
Copy link
Member

@williamdes

Please check the above url.
https://github.com/feathericons/feather/blob/master/LICENSE

Perfect, would you mind copying the license file in the folder please?

Also it would be nice to only have scss files and not compiled css files

cc @MauricioFauth

@khadkamhn
Copy link
Contributor Author

@williamdes

I have added the LICENSE file of that font and the SCSS files already exist.

@AppCarde

This comment was marked as resolved.

Sign in to view
@williamdes williamdes self-assigned this Apr 9, 2022
@williamdes williamdes mentioned this pull request Apr 9, 2022
Closed
@williamdes
Copy link
Member

@williamdes

I have added the LICENSE file of that font and the SCSS files already exist.

Thank you !
Wow near one year already past..

@MauricioFauth could you help with the review ?

@williamdes
Copy link
Member

I just tried this theme and it needs some fixing to work on 5.1 and a bit more for 5.2
Apart from that it really looks good and cool !
The icons are very nice

@williamdes williamdes marked this pull request as draft May 24, 2022 14:32
@khadkamhn khadkamhn marked this pull request as ready for review May 25, 2022 09:24
khadkamhn
khadkamhn commented Nov 23, 2022
View reviewed changes
Copy link
Contributor Author

@khadkamhn khadkamhn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williamdes @MauricioFauth

The theme is now updated to meet the basic compatibility with 5.1 & 5.2

williamdes
williamdes reviewed Dec 3, 2022
View reviewed changes
fistu/theme.json Outdated Show resolved Hide resolved
@williamdes
Copy link
Member

I am keeping this on hold until I review it. Thank you for the recent changes !
You can git reset --hard on your remote master branch, I force pushed it to clean up the history and fix this PR

@williamdes
Copy link
Member

On 5.2 I found this bug

image

@williamdes williamdes removed the request for review from MauricioFauth January 1, 2023 07:17
@williamdes williamdes changed the title New theme added for compatible with 5.x New 5.1/5.2 theme fistu Jan 1, 2023
@williamdes williamdes merged commit 992550e into phpmyadmin:master Jan 1, 2023
@williamdes
Copy link
Member

I force pushed your branch and updated your css files, also updated bootstrap.scss
You can hard reset onto the master branch and create a new branch for your fixes for 5.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@williamdes williamdes

Labels
new-theme A request to add a new theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khadkamhn @williamdes @AppCarde