New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme darkwolf for phpMyAdmin 5.2 #82
Conversation
I am thinking about re-working our theme process to only have to upload scss files and a CI job would build the CSS files |
Hi @williamdes ....Thanks for answering. I've edited a bit of SCSS, I'm not very familiar with it, but I think it's just a matter of studying to expand knowledge. |
Just to be sure: do you want to update your |
7ad7b2c
to
a9b94d8
Compare
Thank you for your patience ! |
I consider that updating the theme is the best, I hope that most of you will keep updated phpMyAdmin to the most recent version so that it works well, since from now on I will only update darkwolf for the bootstrap theme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The theme looks good and has no files that require license information.
That said I would ask two questions:
- Can this theme be re-build from it's scss files (my testing shows that no) ?
- Did you modify the
.css
file directly ?
Okay, so I will proceed to renaming to |
Yes, I modified the file directly from the .css In future updates I will do it directly from .scss |
Okay, I think we can then update the theme and wait for your scss updates :) |
960741c
to
64a4039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also modify darkwolf/css/theme.rtl.css
?
That's right, I also modified theme.rtl.css |
For this darkwolfbootstrap theme, I would greatly appreciate your help in the scss compilation, for future versions or updates of the theme I would be doing it myself. |
I've uploaded this and it's now available at https://web.phpmyadmin.net/themes/#pma_5_2. Many thanks for your contribution! |
I would add the verification of this theme and have the possibility that it can be downloaded from https://www.phpmyadmin.net/themes/
Thank you very much
darkwolfbootstrap.zip