Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme darkwolf for phpMyAdmin 5.2 #82

Merged
merged 1 commit into from Oct 23, 2022

Conversation

SteppenWolf68
Copy link
Contributor

I would add the verification of this theme and have the possibility that it can be downloaded from https://www.phpmyadmin.net/themes/

Thank you very much

darkwolfbootstrap.zip

@williamdes
Copy link
Member

I am thinking about re-working our theme process to only have to upload scss files and a CI job would build the CSS files
By the way, do you use and edit scss files?
And also write some indications for users to be able to test and write new themes

@SteppenWolf68
Copy link
Contributor Author

Hi @williamdes ....Thanks for answering.

I've edited a bit of SCSS, I'm not very familiar with it, but I think it's just a matter of studying to expand knowledge.
We have to be updated as much as possible or we will be stuck.
In addition, all the work you do is always to improve and we must adapt and learn hand in hand with you.

@williamdes williamdes added the theme-update A request to update an existing theme label Aug 23, 2022
@williamdes
Copy link
Member

Hi @williamdes ....Thanks for answering.

I've edited a bit of SCSS, I'm not very familiar with it, but I think it's just a matter of studying to expand knowledge. We have to be updated as much as possible or we will be stuck. In addition, all the work you do is always to improve and we must adapt and learn hand in hand with you.

Just to be sure: do you want to update your darkwolf theme or create a new one ?

@williamdes williamdes added new-theme A request to add a new theme and removed theme-update A request to update an existing theme labels Aug 23, 2022
@williamdes
Copy link
Member

Hi @williamdes ....Thanks for answering.

I've edited a bit of SCSS, I'm not very familiar with it, but I think it's just a matter of studying to expand knowledge. We have to be updated as much as possible or we will be stuck. In addition, all the work you do is always to improve and we must adapt and learn hand in hand with you.

Thank you for your patience !
I just added documentation, let me know how it works for you: https://github.com/phpmyadmin/themes#how-to-contribute

@SteppenWolf68
Copy link
Contributor Author

I consider that updating the theme is the best, I hope that most of you will keep updated phpMyAdmin to the most recent version so that it works well, since from now on I will only update darkwolf for the bootstrap theme.
I really appreciate your help and patience with me.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theme looks good and has no files that require license information.
That said I would ask two questions:

  • Can this theme be re-build from it's scss files (my testing shows that no) ?
  • Did you modify the .css file directly ?

@williamdes
Copy link
Member

I consider that updating the theme is the best, I hope that most of you will keep updated phpMyAdmin to the most recent version so that it works well, since from now on I will only update darkwolf for the bootstrap theme. I really appreciate your help and patience with me.

Okay, so I will proceed to renaming to darkwolf in some of the next updates of this PR

@SteppenWolf68
Copy link
Contributor Author

SteppenWolf68 commented Aug 23, 2022

The theme looks good and has no files that require license information. That said, I would ask two questions:

  • Can this theme be rebuilt from its scss files (my tests show no)?
  • Did you modify the file directly?.css

Yes, I modified the file directly from the .css

In future updates I will do it directly from .scss

@williamdes
Copy link
Member

Okay, I think we can then update the theme and wait for your scss updates :)
Do you need some help compiling scss ?

@williamdes williamdes changed the title Theme darkwolfbootstrap for phpMyAdmin 5.2 Theme darkwolf for phpMyAdmin 5.2 Aug 24, 2022
@williamdes williamdes added theme-update A request to update an existing theme and removed new-theme A request to add a new theme labels Aug 24, 2022
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also modify darkwolf/css/theme.rtl.css ?

@SteppenWolf68
Copy link
Contributor Author

Did you also modify darkwolf/css/theme.rtl.css ?

That's right, I also modified theme.rtl.css

@SteppenWolf68
Copy link
Contributor Author

Okay, I think we can then update the theme and wait for your scss updates :) Do you need some help compiling scss ?

For this darkwolfbootstrap theme, I would greatly appreciate your help in the scss compilation, for future versions or updates of the theme I would be doing it myself.
Really thank you very much for all your help.
Cheers

@ibennetch ibennetch merged commit ba618f1 into phpmyadmin:master Oct 23, 2022
@ibennetch
Copy link
Member

I've uploaded this and it's now available at https://web.phpmyadmin.net/themes/#pma_5_2.

Many thanks for your contribution!

@williamdes williamdes self-assigned this Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme-update A request to update an existing theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants