You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unknown constant used as default parameter in \PhpOffice\PhpSpreadsheet\Settings::setCacheStorageMethod public static function setCacheStorageMethod($method = CachedObjectStorageFactory::cache_in_memory, $arguments = [])
The text was updated successfully, but these errors were encountered:
I've created pull request for this issue.
Not sure if I've done that properly. According to the documentation:
If you are going to be submitting a pull request, please fork from develop, and submit your pull request back as a fix/feature branch referencing the GitHub issue number
So, I have to create the issue, create branch named as Issue (issue ID?) and then create pull request? Right?
What you did was fine. You don't necessarily need to create an issue, but you have to create a branch, possibly named after the issue or something understandable.
Next time, if there is an open issue then you may mention it in the commit message such as "FIX #24" so that the issue is automatically closed when we merge the PR.
Unknown constant used as default parameter in \PhpOffice\PhpSpreadsheet\Settings::setCacheStorageMethod
public static function setCacheStorageMethod($method = CachedObjectStorageFactory::cache_in_memory, $arguments = [])
The text was updated successfully, but these errors were encountered: