Fix tags parser #17
Merged
Fix tags parser #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tags parser when there's a blank line between tags.
gossi
reviewed
Mar 28, 2021
| @@ -184,7 +184,7 @@ protected function parseTags(string $tags): void { | |||
| foreach (explode("\n", $tags) as $line) { | |||
| if ($this->isTagLine($line) || count($result) == 0) { | |||
| $result[] = $line; | |||
| } else { | |||
| } elseif ($line !== '') { | |||
There was a problem hiding this comment.
Nope, because we lose indentation spaces for multiline comments. I.e. parsing and re-writing a comment like the following
/**
* @var Awesome and shiny clear description
* of the variable.
* /results in the(exactly)same docblock.
If we trim, the result will be:
/**
* @var Awesome and shiny clear description
* of the variable.
* /There was a problem hiding this comment.
ah ok... just wanted to be sure, when a check for empty string happens, that usually goes with trim, so we are good 👍
gossi
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tag parser when there's a blank line between tags.
I added a test which fails without this commit.