Issue #1367

Use `zval_get_long` instead of `Z_STRVAL_P` + `atof` for parsing timeout and read_timeout params.
phpredis · Jul 29, 2018 · 7171ace · 7171ace
1 parent 0858f08
commit 7171ace
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/redis_session.c b/redis_session.c
@@ -469,10 +469,10 @@ PS_OPEN_FUNC(redis)
                     weight = zval_get_long(param);
                 }
                 if ((param = zend_hash_str_find(Z_ARRVAL(params), "timeout", sizeof("timeout") - 1)) != NULL) {
-                    timeout = atof(Z_STRVAL_P(param));
+                    timeout = zval_get_double(param);
                 }
                 if ((param = zend_hash_str_find(Z_ARRVAL(params), "read_timeout", sizeof("read_timeout") - 1)) != NULL) {
-                    read_timeout = atof(Z_STRVAL_P(param));
+                    read_timeout = zval_get_double(param);
                 }
                 if ((param = zend_hash_str_find(Z_ARRVAL(params), "persistent", sizeof("persistent") - 1)) != NULL) {
                     persistent = (atol(Z_STRVAL_P(param)) == 1 ? 1 : 0);