Obtain a read only session if session lock fails #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a session lock fails to obtain, use a read only version of the session. This causes less backwards compatible issues and was introduced between the 5.3.7 and 6.0.0 releases. New note added to suggest the session is read only Fixes phpredis#2382
|
Any update on this? |
fwilliamconceicao
approved these changes
Oct 27, 2023
|
I'm not sure that this is a good idea to ignore error when lock is not acquired |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a session lock fails to obtain, use a read only version of the session. This causes less backwards compatible issues and was introduced between the 5.3.7 and 6.0.0 releases.
New note added to suggest the session is read only
Fixes #2382
Introduced here
687a0b4#diff-d7896829bc47f45d33720c352a4b8aabd4dca447b6db9e2d4205be5b44ba5d9eR714