use pkg-config for libzstd and liblzf #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have pkg-config, so while if I install it the update works, but without pkg-config new logic does not work. |
|
Also needed for lz4 |
remicollet
force-pushed
the
issue-pkgconfig
branch
from
2f4f2a7
to
a88186c
Compare
|
@michael-grunder @yatsukhnenko nice to have in 5.3.0RC2 |
|
@remicollet thanks 👍 |
|
I cherry-picked the relevant commits 😄 I'm going to see if it's not too hard to get the lz4 tests running in Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which seems far more reliable that file heuristic