Relax requirements on set's expire argument

[michael-grunder]

See: #1783

[yatsukhnenko]

Don't we need add check for IS_DOUBLE and additional check is_numeric_string for IS_STRING?

[michael-grunder]

Good point, we should accept IS_DOUBLE zvals as well.

I'm not sure how much is_numeric_string gets us because I believe non-strings will resolve to 0 which will fail before sending the command because I verify that the TTL is greater than zero.

I suppose it would let us be even more specific about the error but I'm not sure it's worth the extra logic.

[michael-grunder]

@yatsukhnenko Does the latest change look good to you?

[yatsukhnenko]

@michael-grunder I want to check how it will work with non-numeric strings

[michael-grunder]

What happens is that a non-numeric string (e.g. 'foo') converts to 0 and you get a warning about TTL < 1

<?php

$obj_r = new Redis();
$obj_r->connect('localhost', 6379);
var_dump($obj_r->set('foo', 'bar', 'notastring'));
?>

$ sapi/cli/php setex.php 

Warning: Redis::set(): EXPIRE can't be < 1 in /home/mike/dev/phpfarm/src/php-7.4.8-debug/setex.php on line 6
bool(false)

I suppose there is a risk of doing something like this:

$obj_r->set('foo', 'bar', '12345notastring');
?>

I don't mind also using is_numeric_string to make it impossible to use incorrectly.

[yatsukhnenko]

I worried about strings like that 12345notastring

[michael-grunder]

Merged, but now that I look at the code I think I should probably also use redis_try_get_expiry in the case where our user passes an options array.