You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've made a base module which actually just contains a bunch of distributed static analysis files. For tools like phpcs, phpstan and such. And, obviously, also for grumphp. The distribution files in this module are installed through composer and end up in the vendor directory. They can be used as import in the 'root' configuration files or directly.
The bug is happening when we have a grumphp.yml file in the root of the project, which imports a grumphp.yml.dist file from a vendor location. The bug specifically occurs when the imported file is a .dist file. When this imported file not a dist, but a .yml the bug does not occur. It doesn't really matter where this .dist file is located.
The bug concerns the src/Configuration/Loader/DistFileLoader.php which doesn't (correctly) resolve the path to the dist file. In comparison; the Symfony YamlFileLoader (which is used if you import a .yml file) does resolve the path to the yml file correctly.
2.5.0
We've made a base module which actually just contains a bunch of distributed static analysis files. For tools like phpcs, phpstan and such. And, obviously, also for grumphp. The distribution files in this module are installed through composer and end up in the vendor directory. They can be used as import in the 'root' configuration files or directly.
The bug is happening when we have a
grumphp.yml
file in the root of the project, which imports agrumphp.yml.dist
file from a vendor location. The bug specifically occurs when the imported file is a.dist
file. When this imported file not a dist, but a.yml
the bug does not occur. It doesn't really matter where this.dist
file is located.The bug concerns the
src/Configuration/Loader/DistFileLoader.php
which doesn't (correctly) resolve the path to the dist file. In comparison; the SymfonyYamlFileLoader
(which is used if you import a.yml
file) does resolve the path to the yml file correctly.Configuration which doesn't work (aka the bug)
or
Configuration which works
or
The error output concerning the bug is as follows.
The text was updated successfully, but these errors were encountered: