Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeception XML/HTML reporting support to grumphp #1107

Merged
merged 4 commits into from Sep 14, 2023

Conversation

petrisorciprian-vitals
Copy link
Contributor

Q A
Branch v2.x
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets -

Codeception allows generating HTML/XML reports after test runs, which is very useful for CI and/or sharing results.
Currently, this is not possible within grumphp, except through a shell script which invokes codeception manually.

This PR adds the capability for the Codeception task to output XML/HTML reports.

Codeception supports generating XML and HTML reporting options for test results.

This is very useful in CI environments or to share test reports, it would be nice if grumphp could be configured to generate them as well.
@@ -60,6 +60,8 @@ public function run(ContextInterface $context): TaskResultInterface
$arguments->add('run');
$arguments->addOptionalArgument('--config=%s', $config['config_file']);
$arguments->addOptionalArgument('--fail-fast', $config['fail_fast']);
$arguments->addOptionalArgument('--xml', $config['xml']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to configure these available options in getConfigurableOptions() as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@veewee veewee added this to the 2.1.0 milestone Sep 14, 2023
@veewee
Copy link
Contributor

veewee commented Sep 14, 2023

Thanks for the PR.
You are almost there: only the options configuration is missing.

@veewee veewee merged commit fb70da3 into phpro:v2.x Sep 14, 2023
10 checks passed
@veewee
Copy link
Contributor

veewee commented Sep 14, 2023

Looks good, thanks again! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants