Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check config filename existence at getRelativePath() #34

Conversation

igormukhingmailcom
Copy link
Contributor

No description provided.

$this->beConstructedWith($config, $fileSystem);
}

function it_is_initializable()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to keep this example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, don't understand what you mean.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the entire it_is_initializable() example, it's not very useful. :)

@aderuwe
Copy link
Contributor

aderuwe commented Sep 4, 2015

@igormukhingmailcom thanks for the pull request, just a few things to clean up if you would. :)

aderuwe added a commit that referenced this pull request Sep 4, 2015
…fig-existance

Check config filename existence at getRelativePath()
@aderuwe aderuwe merged commit f8ba864 into phpro:master Sep 4, 2015
@aderuwe
Copy link
Contributor

aderuwe commented Sep 4, 2015

Thank you @igormukhingmailcom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants