[WIP] Upgrade PHP 7.0 #511
Conversation
There was a problem hiding this comment.
At first sight, the changes look pretty good.
As mentioned before: this PR is way too big to review. Once the comments are resolved, we will merge this one to a separate branch from where we can add more improvements.
I'll be using that branch on my projects, but I mostly use +- 8 tasks. We should find a way to validate if the changes also work on the other tasks.
This codebase is also a bit behind master ;)
spec/Parser/Php/PhpParserSpec.php
Outdated
| @@ -34,42 +34,42 @@ function it_is_initializable() | |||
| { | |||
| $this->shouldHaveType(PhpParser::class); | |||
| } | |||
| // todo! | |||
spec/Task/AtoumSpec.php
Outdated
| ContextInterface $context, | ||
| ProcessFormatterInterface $formatter | ||
| ) { | ||
| $formatter->format($process)->willReturn(Argument::type('string')); |
There was a problem hiding this comment.
Lets avoid using the Argument::type(...) in a will* statement.
This only works because there is a \Prophecy\Argument\Token\TypeToken::__toString() method.
If you want to use a diferent type like integer, you'll get:
Argument::type('integer')
notice: Object of class Prophecy\Argument\Token\TypeToken could not be converted to int
I prefer to just return a string instead. (This one is being used all over the newly introduces spec changes)
spec/Task/Git/BranchNameSpec.php
Outdated
| $result = $this->run($context); | ||
| $result->isPassed()->shouldBe(false); | ||
| } | ||
| // function it_should_have_configurable_options() |
There was a problem hiding this comment.
These specs should be working
spec/Task/ShellSpec.php
Outdated
| $scripts[0]->shouldBe(['script.sh']); | ||
| $scripts[1]->shouldBe(['command', 'arg1', 'arg2']); | ||
| } | ||
| // todo |
spec/Task/ShellSpec.php
Outdated
| $result->isPassed()->shouldBe(false); | ||
| } | ||
| // function it_does_not_do_anything_if_there_are_no_files(ProcessBuilder $processBuilder, ContextInterface $context) | ||
| // { |
src/Util/Composer.php
Outdated
| */ | ||
| public static function loadRootPackageFromJson($json, Config $config = null) | ||
| public static function loadRootPackageFromJson($json, Config $config = null): \Composer\Package\RootPackageInterface |
src/Util/Composer.php
Outdated
| * @return \Composer\Config | ||
| */ | ||
| public static function loadConfiguration() | ||
| public static function loadConfiguration(): \Composer\Config |
src/Util/PhpVersion.php
Outdated
| * @see https://secure.php.net/supported-versions.php for a list of currently supported versions | ||
| */ | ||
| public function isSupportedVersion($currentVersion) | ||
| public function isSupportedVersion(string $currentVersion): bool |
There was a problem hiding this comment.
Keep the information in the docblocks
| * @return bool | ||
| */ | ||
| public function isSupportedProjectVersion($currentVersion, $projectVersion) | ||
| public function isSupportedProjectVersion(string $currentVersion, string $projectVersion): bool |
There was a problem hiding this comment.
Keep information in docblocks
| $this->assertEquals(ParseError::TYPE_ERROR, $errors[0]->getType()); | ||
| $this->assertEquals(2, $errors[0]->getLine()); | ||
| } | ||
| // todo |
Landerstraeten
force-pushed
the
upgrade-7.0
branch
2 times, most recently
from
799120e
to
3114418
Compare
spec/Task/Git/BranchNameSpec.php
Outdated
| $result = $this->run($context); | ||
| $result->isPassed()->shouldBe(false); | ||
| } | ||
| // todo: need help |
There was a problem hiding this comment.
@veewee I need help on this one
Make detection of strict types compatible with PhpParser 4.
Correct package-name of phan
* Only run question helper in interactive mode * Omit default argument
* Psalm task spec test * Psalm task * Added Psalm to tasks.yml * Added more options * Added vimeo/psalm to suggestions * Created docs for Psalm task * Added psalm to README.md * Added Psalm to tasks.md * Added description for threads parameter * Threads is set to null by default * Files are only added on pre-commit context * Add newlines
Landerstraeten
force-pushed
the
upgrade-7.0
branch
from
dd0ba65
to
5da397f
Compare
Signed-off-by: Lander Vanderstraeten <lander.vanderstraeten@phpro.be>
No description provided.