Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty body #2

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Allow empty body #2

merged 1 commit into from
Oct 2, 2020

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Oct 2, 2020

Q A
Type bug
BC Break yes
Fixed issues

Summary

Some services are not happy with e.g. an empty json body.

For example:

This succeeds

curl https://login.microsoftonline.com/common/v2.0/.well-known/openid-configuration -H'Content-Type: application/json'

This fails with message 'bad request':

curl https://login.microsoftonline.com/common/v2.0/.well-known/openid-configuration -d'[]' -H'Content-Type: application/json'

Therefor, I changed the RequestInterface::body() method so that it can return an array|null

@veewee veewee added this to the 0.2.0 milestone Oct 2, 2020
@veewee veewee added the enhancement New feature or request label Oct 2, 2020
@veewee veewee merged commit 75a401f into phpro:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veewee