Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create method #4

Closed
anibalsanchez opened this issue Sep 23, 2017 · 3 comments
Closed

create method #4

anibalsanchez opened this issue Sep 23, 2017 · 3 comments

Comments

@anibalsanchez
Copy link

Amazing stuff!!

I understand that the method to create instances is instance... and that's mainly because of Joomla's current practice.

To depart from the old practice, I'd love to have the verb to the action of object creation as create... it could be simply an alias.

Again, thank you @phproberto !

@phproberto
Copy link
Owner

Thanks for the feedback. I really appreciate you took the time to review it.

I agree the name is developer oriented and bad semantically. Rolando suggested to use find at JoomlaDay Vigo and I think is a good choice. I will change it.

Thanks again.

@phproberto
Copy link
Owner

I've sent a PR: #6

Let me know your thoughts about it.

Let's close this and discuss it there.

Thanks again for the feedback!

@anibalsanchez
Copy link
Author

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants