Skip to content

Commit

Permalink
don't test on PHP 5.6
Browse files Browse the repository at this point in the history
  • Loading branch information
@terrafrost
terrafrost committed Feb 23, 2024
1 parent bbb7633 commit f61ab08
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
php-version: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
php-version: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']

1 comment on commit f61ab08

@terrafrost
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In mcrypt_compat 2.0 phpseclib_mcrypt_generic_deinit was modified to so that $td was passed by reference. This was done so that reflection could be used to change the visibility of a variable that phpseclib 3.0 made private (in phpseclib 2.0 all class variables were implicitly public). Because of that you can't do call_user_func($prefix . 'mcrypt_generic_deinit', $td); (doing so will give you a "Parameter 1 to phpseclib_mcrypt_generic_deinit() expected to be a reference, value given" error) - you have to do ($prefix . 'mcrypt_generic_deinit')($td);. Only problem with that is that that only works on PHP 7.0+, hence why PHP 5.6 is being dropped.

Reference:

6505669#diff-6b32a7cea48ba353a2295cad1c8042b0c3978f461a74bab5bb7dfc7df6158246L777

Please sign in to comment.