Composer: let mcrypt_compat "provide" mcrypt req

[terrafrost]

No description provided.

[Alanaktion]

This really adds a lot of value to this package. Without it, it's possible to work around an ext-mcrypt requirement using --ignore-platform-reqs, but that can have other side effects that wouldn't be an issue if this were merged.

[terrafrost]

The problem I have with merging this is that it breaks the unit tests. In particular, I get the following error:

[InvalidArgumentException]                     
  Package is not installed: ext-mcrypt-7.0.26.0

Any ideas as to how I can fix this?

[ravage84]

@terrafrost, I couldn't reproduce your issue. Though I've used PHP 7.1 on Windows for a quick setup. How did you get that error?

I also think many could benefit from your compat library, as I mentioned in #13.

[terrafrost]

@ravage84 - it's reproducible on Travis CI. Even your PR (#13) failed..

[ravage84]

@terrafrost excuse my ignorance 🙇

It seems it's a Composer bug. I did some debugging and confirmed a behavior that has already been mentioned by someone else:

composer/composer#7086

I guess Composer should ignore php extensions when looking which package (library) makes which package obsolete.

[Alanaktion]

There is another option that works reasonably well if you just need to install other Composer libraries that depend on ext-mcrypt. Requiring this library, then adding a config section to your composer.json can work to tell Composer to assume the extension is actually installed.

{
    "require": {
        "phpseclib/mcrypt_compat": "^1.0",
        // ...
    },
    "config": {
        "platform": {
            "ext-mcrypt": "1.0.0"
        }
    }
}

[glensc]

the value should be version, so use 0 or minimum (uppper?) php api you support

the native extension matches PHP_VERSION:

$ php -r '$r = new ReflectionExtension("mcrypt"); var_dump($r->getVersion());'
Command line code:1:
string(6) "7.1.25"

[terrafrost]

That seemed to do the trick! I went ahead and made it provide 5.6.40 (the last 5.6 version) since mcrypt was removed in 7.0.0. I've gone ahead and made a new release as well.

Thanks!

[glensc]

for travis. add this fragment:

$ composer config platform.ext-mcrypt '0'

then downstream projects do not need to hack with their composer.json, as that solution is not flexible as composer.json/composer.lock are committed to repo usually, and i have no choice to use real extension, this compat lib or have a failure in dependency resolution.

[glensc]

here's project that uses ext provide successfully:

• https://github.com/alcaeus/mongo-php-adapter/blob/1.1.6/composer.json#L21-L23

[terrafrost]

4c97e9b does this.

Thanks!